Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git_trac to the latest commit of the repository #18477

Closed
nathanncohen mannequin opened this issue May 22, 2015 · 15 comments
Closed

Update git_trac to the latest commit of the repository #18477

nathanncohen mannequin opened this issue May 22, 2015 · 15 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 22, 2015

By updating Sage's shipped version of git_trac, we make it possible to checkout tickets without having a trac account.

http://www.steinertriples.fr/ncohen/tmp/git_trac-20150522.tar.bz2

CC: @jdemeyer @vbraun @videlec

Component: packages: standard

Author: Nathann Cohen

Branch: 2fd06da

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/18477

@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone May 22, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 22, 2015

Commit: 08af769

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 22, 2015

Branch: public/18477

@nathanncohen

This comment has been minimized.

@nathanncohen nathanncohen mannequin changed the title Update git_trac to the latest commit of the repo Update git_trac to the latest commit of the repository May 23, 2015
@jdemeyer
Copy link

comment:5

The tarball is missing a top-level directory (usually called src in Sage).

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 23, 2015

comment:6

Arg, sorry for that. I built it with "git archive" but it was not such a good idea after all. Will be fixed in a second.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2fd06datrac #18477: Update git_trac to the latest commit of the repository

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2015

Changed commit from 08af769 to 2fd06da

@jdemeyer
Copy link

jdemeyer commented Jun 3, 2015

comment:9

I would be even better if git trac checkout ... would automatically run git trac config if needed, but this is already nice.

@jdemeyer
Copy link

jdemeyer commented Jun 3, 2015

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jun 3, 2015

Changed branch from public/18477 to 2fd06da

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 4, 2015

Changed commit from 2fd06da to none

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 4, 2015

comment:12

I would be even better if git trac checkout ... would automatically run git trac config if needed, but this is already nice.

Well. In terms of 'clean code', what would you think of a way to decorate functions which use a remote? The decorator would check that the remotes exist, and if they do not create them before running the function? Or do you think that it's 'oversolving' the problem?

Nathann

@jdemeyer
Copy link

jdemeyer commented Jun 4, 2015

comment:13

Replying to @nathanncohen:

Well. In terms of 'clean code', what would you think of a way to decorate functions which use a remote? The decorator would check that the remotes exist, and if they do not create them before running the function?

I think that's a good solution. Just make sure that the "ensure that the trac remote exists" function is cached, in case a scripts needs to call those functions many times.

But really, this is Volker's code, so it's better to ask him.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 4, 2015

comment:14

I think that's a good solution.

I trust your sense of 'cleanness' more than I trust mine on those matters.

But really, this is Volker's code, so it's better to ask him.

Yes of course.

Nathann

@vbraun
Copy link
Member

vbraun commented Jun 4, 2015

comment:15

This is sagemath/git-trac-command#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants