pyflakes cleanup of interfaces

[fchapoton]

pyflakes finds many small problems in many interfaces

let's correct them all

Component: interfaces

Author: Frédéric Chapoton

Branch/Commit: e6cd26f

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/18490

[fchapoton]

Branch: u/chapoton/18490

[fchapoton]

Commit: b226acd

[fchapoton]

New commits:

b226acd

large scale pyflakes cleanup of interfaces

[a-andre]

comment:2

There are still some problems

$ pyflakes-python2 src/sage/interfaces/*.py

src/sage/interfaces/chomp.py:670: list comprehension redefines 'x' from line 665
src/sage/interfaces/expect.py:60: 'AsciiArtString' imported but unused
src/sage/interfaces/maxima_abstract.py:978: local variable 'a' is assigned to but never used
src/sage/interfaces/tests.py:46: 'from all import *' used; unable to detect undefined names

Not sure if we should/can fix the last one.

[fchapoton]

comment:3

At least three of them cannot be fixed.

• maxima_abstract: 'a' is used inside an eval
• tests: this file is testing several interfaces, it is simpler to keep the import *
• expect: this import is there to be imported from other places. So it cannot be removed.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f357233

trac #18490 one more thing in chomp

[sagetrac-git]

Changed commit from b226acd to f357233

[a-andre]

comment:5

Documentation fails to build.

[reference] interfaces:
[reference] WARNING: Unable to fetch /home/user/Development/sage/src/doc/output/doctrees/en/reference/interfaces/environment.pickle
Error building the documentation.

Note: incremental documentation builds sometimes cause spurious
error messages. To be certain that these are real errors, run
"make doc-clean" first and try again.
Traceback (most recent call last):
  File "/home/user/Development/sage/src/doc/common/builder.py", line 1626, in <module>
    getattr(get_builder(name), type)()
  File "/home/user/Development/sage/src/doc/common/builder.py", line 292, in _wrapper
    getattr(get_builder(document), 'inventory')(*args, **kwds)
  File "/home/user/Development/sage/src/doc/common/builder.py", line 516, in _wrapper
    getattr(DocBuilder(self.name, lang), format)(*args, **kwds)
  File "/home/user/Development/sage/src/doc/common/builder.py", line 110, in f
    eval(compile(open(sys.argv[0]).read(), sys.argv[0], 'exec'))
  File "/home/user/Development/sage/src/doc/common/custom-sphinx-build.py", line 219, in <module>
    raise OSError(ERROR_MESSAGE)
OSError: [reference] WARNING: Unable to fetch /home/user/Development/sage/src/doc/output/doctrees/en/reference/interfaces/environment.pickle

[fchapoton]

comment:6

yes, indeed. no idea where this can come from ?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e6cd26f

trac #18490 found a bad unicode character

[sagetrac-git]

Changed commit from f357233 to e6cd26f

[a-andre]

comment:9

LGTM

[a-andre]

Reviewer: André Apitzsch

[vbraun]

Changed branch from u/chapoton/18490 to e6cd26f