Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posets: Minor docstring polishing to min and max elements #18491

Closed
jm58660 mannequin opened this issue May 24, 2015 · 11 comments
Closed

Posets: Minor docstring polishing to min and max elements #18491

jm58660 mannequin opened this issue May 24, 2015 · 11 comments
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-6.8

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented May 24, 2015

Some crosslinking.

CC: @nathanncohen

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: 3df9b4e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18491
@jm58660 jm58660 mannequin added c: combinatorics labels May 24, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 24, 2015

Branch: u/jmantysalo/posets__minor_docstring_polishing_to_min_and_max_elements

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 24, 2015

Commit: 597091b

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 24, 2015

comment:2

Happen this one never be reviewed, no animals will be harm.

New commits:

597091bCrosslinks. One typo. No code changes.

@jm58660 jm58660 mannequin added the s: needs review label May 24, 2015
@jm58660 jm58660 mannequin added this to the sage-6.8 milestone May 24, 2015
@jm58660 jm58660 mannequin removed the wishlist item label May 24, 2015
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

lgtm

@fchapoton
Copy link
Contributor

comment:5

wrong doc in has_bottom

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Changed commit from 597091b to 3df9b4e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3df9b4eMaximal -> minimal.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented May 24, 2015

comment:7

Duh. Corrected.

@jm58660 jm58660 mannequin added s: needs review and removed s: needs work labels May 24, 2015
@fchapoton
Copy link
Contributor

comment:8

good now

@vbraun
Copy link
Member

vbraun commented May 25, 2015

Changed branch from u/jmantysalo/posets__minor_docstring_polishing_to_min_and_max_elements to 3df9b4e

@vbraun vbraun closed this as completed in 65986e6 May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @fchapoton