Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build/install after #17607 #18517

Closed
jdemeyer opened this issue May 26, 2015 · 10 comments
Closed

Clean up build/install after #17607 #18517

jdemeyer opened this issue May 26, 2015 · 10 comments

Comments

@jdemeyer
Copy link

Instead of creating totally new package types like python2standard, adding the following lines in build/install is sufficient to implement #17607:

if [ "$SAGE_PYTHON3" = yes ]; then
    echo >&5 'PYTHON = $(PYTHON3)'
else
    echo >&5 'PYTHON = $(PYTHON2)'
fi

Depends on #17607

CC: @ohanar @vbraun @nathanncohen

Component: build

Author: Jeroen Demeyer

Branch/Commit: 7e5095c

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/18517

@jdemeyer jdemeyer added this to the sage-6.8 milestone May 26, 2015
@jdemeyer
Copy link
Author

Dependencies: #17607

@jdemeyer
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

7e5095cUse $MAKE instead of make

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2015

Commit: 7e5095c

@jdemeyer

This comment has been minimized.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 26, 2015

comment:5

Looks good to me. Should we rename the packages from python to python2 and from Python to python3 in this ticket?

Nathann

@jdemeyer
Copy link
Author

comment:6

Replying to @nathanncohen:

Should we rename the packages from python to python2 and from Python to python3 in this ticket?

I prefer not.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 26, 2015

comment:7

I prefer not.

I don't see why, but so be it.

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 26, 2015

Reviewer: Nathann Cohen

@vbraun
Copy link
Member

vbraun commented May 26, 2015

Changed branch from u/jdemeyer/clean_up_build_install_after__17607 to 7e5095c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants