Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cdefs.pxi from .pxd/.pxi files #18519

Closed
jdemeyer opened this issue May 26, 2015 · 10 comments
Closed

Remove cdefs.pxi from .pxd/.pxi files #18519

jdemeyer opened this issue May 26, 2015 · 10 comments

Comments

@jdemeyer
Copy link

To continue #18455, we remove cdefs.pxi from all .pxi/.pxd files.

We also fold fplll.pxi and singular-cdefs.pxi in the corresponding .pxd files.

Depends on #18455

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 11bd576

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/18519

@jdemeyer jdemeyer added this to the sage-6.8 milestone May 26, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/18519

@jdemeyer
Copy link
Author

New commits:

2ed346bRemove unneeded inclusions of cdefs.pxi
57e9278More removals of cdefs.pxi
370106dEven more removals of cdefs
1accad6Remove cdefs.pxi from .pxd/.pxi files

@jdemeyer
Copy link
Author

Commit: 1accad6

@jdemeyer jdemeyer changed the title Remove cdefs.pxi from .pxd/.pxi Remove cdefs.pxi from .pxd/.pxi files May 26, 2015
@mezzarobba
Copy link
Member

comment:4

In the following comment (moved from singular-cdefs.pxi to singular/decl.pxd), is “deferences” a typo for “references” or a technical term I don't know?

+NOTE: our ring, poly etc. types are not the SINGULAR ring, poly,
+etc. types. They are deferences. So a SINGULAR ring is a ring pointer
+here.

@jdemeyer
Copy link
Author

comment:5

I think it's a typo for "dereferences" although I don't know if that is a correct noun.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2015

Changed commit from 1accad6 to 11bd576

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

11bd576Clarify note

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Jun 2, 2015

Changed branch from u/jdemeyer/ticket/18519 to 11bd576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants