Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3: The semantic of map() function is changed (addendum 1) #18531

Closed
wluebbe mannequin opened this issue May 28, 2015 · 10 comments
Closed

Python 3: The semantic of map() function is changed (addendum 1) #18531

wluebbe mannequin opened this issue May 28, 2015 · 10 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-6.8

Comments

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented May 28, 2015

This ticket is part of #16073 to simplify review.

In Py2 map() returns a list, while in Py3 map() returns an iterator.

CC: @a-andre

Component: misc

Author: Wilfried Luebbe

Branch/Commit: 93673ca

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/18531
@wluebbe wluebbe mannequin added this to the sage-6.8 milestone May 28, 2015
@wluebbe wluebbe mannequin added p: major / 3 labels May 28, 2015
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

comment:1

A new batch of corrections to map().

New commits:

150f5a2Trac #18531: The semantic of map() function is changed in Python 3

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

Author: Wilfried Luebbe

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

Commit: 150f5a2

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

Branch: u/wluebbe/18531

@wluebbe wluebbe mannequin changed the title Python 3: The semantic of map() function is changed (appendix) Python 3: The semantic of map() function is changed (addendum 1) May 30, 2015
@wluebbe wluebbe mannequin added t: enhancement labels May 30, 2015
@a-andre
Copy link

a-andre commented May 31, 2015

Changed commit from 150f5a2 to 93673ca

@a-andre
Copy link

a-andre commented May 31, 2015

comment:2

I removed a trailing white space and replaced _ by a nicer looking i in some examples.
And letters is already a list, so no need to convert it to one.

If you are happy with my changes, set the ticket to positive review.

@a-andre
Copy link

a-andre commented May 31, 2015

Reviewer: André Apitzsch

@a-andre
Copy link

a-andre commented May 31, 2015

Changed branch from u/wluebbe/18531 to public/18531

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 31, 2015

comment:3

Your changes are fine and the long tests are still OK.

@vbraun
Copy link
Member

vbraun commented Jun 2, 2015

Changed branch from public/18531 to 93673ca

@vbraun vbraun closed this as completed in 3ed535e Jun 2, 2015
@wluebbe wluebbe mannequin mentioned this issue May 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @a-andre