Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3: The semantic of map() function is changed (addendum 2) #18553

Closed
wluebbe mannequin opened this issue May 30, 2015 · 13 comments
Closed

Python 3: The semantic of map() function is changed (addendum 2) #18553

wluebbe mannequin opened this issue May 30, 2015 · 13 comments

Comments

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented May 30, 2015

This ticket is part of #16073 to simplify review.
In Py2 map() returns a list, while in Py3 map() returns an iterator.

CC: @a-andre

Component: misc

Author: Wilfried Luebbe

Branch/Commit: 21537ab

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/18553

@wluebbe wluebbe mannequin added this to the sage-6.8 milestone May 30, 2015
@wluebbe wluebbe mannequin added p: major / 3 labels May 30, 2015
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

comment:1

Another batch of corrections to map().

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 30, 2015

Author: Wilfried Luebbe

@wluebbe wluebbe mannequin added the s: needs review label May 30, 2015
@a-andre
Copy link

a-andre commented May 30, 2015

comment:2

Replying to @wluebbe:

Another batch of corrections to map().

Where? There is no branch attached.

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 31, 2015

Branch: u/wluebbe/18553

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 31, 2015

comment:3

Now there is a branch :-/


New commits:

98d3263Trac #18553: The semantic of map() function is changed in Python 3

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 31, 2015

Commit: 98d3263

@wluebbe wluebbe mannequin added s: needs review and removed s: needs work labels May 31, 2015
@a-andre
Copy link

a-andre commented May 31, 2015

comment:5

Could you change in src/sage/geometry/fan.py

-        facets = [frozenset(_) for _ in [c.ambient_ray_indices() for c in self.generating_cones()] ]
+        facets = [frozenset(c.ambient_ray_indices()) for c in self.generating_cones()]

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

21537abImplement an improvement as suggested by the reviewer.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2015

Changed commit from 98d3263 to 21537ab

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented May 31, 2015

comment:7

Done. Thanx!

@a-andre
Copy link

a-andre commented May 31, 2015

comment:8

LGTM.

@a-andre
Copy link

a-andre commented May 31, 2015

Reviewer: André Apitzsch

@vbraun
Copy link
Member

vbraun commented Jun 2, 2015

Changed branch from u/wluebbe/18553 to 21537ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants