Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite "optional Coin" as "optional cbc" #18559

Closed
nathanncohen mannequin opened this issue May 31, 2015 · 11 comments
Closed

Rewrite "optional Coin" as "optional cbc" #18559

nathanncohen mannequin opened this issue May 31, 2015 · 11 comments
Labels
c: numerical p: major / 3 t: bug
Milestone
sage-6.8

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 31, 2015

Coin is not a sage package, but cbc is.

Nathann

CC: @jdemeyer

Component: numerical

Author: Nathann Cohen

Branch/Commit: 4222223

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18559
@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone May 31, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 31, 2015

Commit: 6d6277f

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 31, 2015

Branch: public/18559

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 31, 2015

New commits:

6d6277ftrac #18559: Rewrite "optional Coin" as "optional cbc"

@nathanncohen nathanncohen mannequin added the s: needs review label May 31, 2015
@fchapoton
Copy link
Contributor

comment:2

Tests do not pass

"hey"

is not the expected answer

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 31, 2015

comment:3

I'm an idiot. I was testing things :-P

I'll update it in a second.

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2015

Changed commit from 6d6277f to 4222223

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4222223trac #18559: Rewrite "optional Coin" as "optional cbc"

@fchapoton
Copy link
Contributor

comment:6

ok, good to go

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 31, 2015

comment:7

Thanks !

@vbraun
Copy link
Member

vbraun commented Jun 2, 2015

Changed branch from public/18559 to 4222223

@vbraun vbraun closed this as completed in 0f8bc89 Jun 2, 2015
@nathanncohen nathanncohen mannequin mentioned this issue Jun 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numerical p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @fchapoton