Warning when installing new-style experimental packages

[nathanncohen]

With #18563, which changes the status of several optional new-style packages to 'experimental', we now need to display a warning when these scripts are installed.

Nathann

Depends on #18563

CC: @vbraun @jdemeyer

Component: packages: experimental

Author: Nathann Cohen

Branch/Commit: 0d344a3

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/18566

[nathanncohen]

Branch: public/18566

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ef11087	Change known-broken packages to "experimental"
37fd689	Valgrind doesn't build on OS X 10.10
b4d152b	trac #18566: Warning when installing new-style experimental packages

[sagetrac-git]

Commit: b4d152b

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

comment:3

I would change

if [ `cat "$PKG_SCRIPTS/type"` == "experimental" ]

to

if [ x`cat "$PKG_SCRIPTS/type"` = xexperimental ]

which has less chances of trouble (in case of a missing/empty type file for example).

[jdemeyer]

comment:4

Instead of

echo # The following message appears twice in this file

couldn't you just make a function warn_experimental() which displays that message?

[sagetrac-git]

Changed commit from b4d152b to 6cafb51

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6cafb51

trac #18566: Bugfix

[nathanncohen]

comment:6

I would change

if [ `cat "$PKG_SCRIPTS/type"` == "experimental" ]

to

if [ x`cat "$PKG_SCRIPTS/type"` = xexperimental ]

Nice. I did not know that corner-case, not that workaround. Done.

[jdemeyer]

comment:7

= instead of == in shell scripts (in POSIX, only = is supported, bash happens to support == also)

[nathanncohen]

comment:8

Yo !

Instead of

echo # The following message appears twice in this file

couldn't you just make a function warn_experimental() which displays that message?

I first did, then decided against it for the following reason: there is one message for experimental packages (appears twice) and one message for archived packages (appears once). As for old-style packages the two messages follow each other, it seemed weird to have one called from a function and another one given explicitly. Plus It would have meant that the new functions would have to be defined in the middle of unrelated code, somewhere else.

So well, I found it cleaner this way.

Nathann

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

40a7807

trac #18566: Bugfix

[sagetrac-git]

Changed commit from 6cafb51 to 40a7807

[jdemeyer]

comment:11

Please rebase to sage-6.8.beta3

[sagetrac-git]

Changed commit from 40a7807 to 0d344a3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0d344a3

trac #18566: Merged with 6.8.beta3

[vbraun]

Changed branch from public/18566 to 0d344a3