Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctest fix for wrong expansion of (x+sqrt(2)*x)^2 #18568

Closed
rwst opened this issue Jun 1, 2015 · 9 comments
Closed

doctest fix for wrong expansion of (x+sqrt(2)*x)^2 #18568

rwst opened this issue Jun 1, 2015 · 9 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-6.8

Comments

@rwst
Copy link

rwst commented Jun 1, 2015

This bug was recently fixed in GiNaC:

sage: ((x+sqrt(2)*x)^2).expand()
2*sqrt(2)*x^2 + 2*x^2 + x^2

This ticket will wait for Pynac to catch up and add a Sage doctest for the case.

CC: @kcrisman

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 4b77d29

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18568
@rwst rwst added this to the sage-6.8 milestone Jun 1, 2015
@rwst rwst changed the title wrong expansion of (x+sqrt(2)*x)^2) wrong expansion of (x+sqrt(2)*x)^2 Jun 1, 2015
@rwst
Copy link
Author

rwst commented Jul 10, 2015

Branch: u/rws/wrong_expansion_of__x_sqrt_2__x__2

@rwst
Copy link
Author

rwst commented Jul 10, 2015

Commit: 4b77d29

@rwst
Copy link
Author

rwst commented Jul 10, 2015

New commits:

4b77d2918568: doctest fix for wrong expansion of (x+sqrt(2)*x)^2

@rwst
Copy link
Author

rwst commented Jul 10, 2015

Changed upstream from Fixed upstream, in a later stable release. to none

@rwst rwst changed the title wrong expansion of (x+sqrt(2)*x)^2 doctest fix for wrong expansion of (x+sqrt(2)*x)^2 Jul 10, 2015
@fchapoton
Copy link
Contributor

comment:5

lgtm

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Aug 9, 2015

comment:6

Author name is missing

@rwst
Copy link
Author

rwst commented Aug 10, 2015

Author: Ralf Stephan

@vbraun
Copy link
Member

vbraun commented Aug 11, 2015

Changed branch from u/rws/wrong_expansion_of__x_sqrt_2__x__2 to 4b77d29

@vbraun vbraun closed this as completed in f0aaad4 Aug 11, 2015
@rwst rwst mentioned this issue Jul 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
3 participants
@vbraun @rwst @fchapoton