Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of tides package #18573

Closed
jdemeyer opened this issue Jun 1, 2015 · 10 comments
Closed

Fix build of tides package #18573

jdemeyer opened this issue Jun 1, 2015 · 10 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 1, 2015

tides has this in upstream's Makefile.am:

AM_CPPFLAGS = -I/usr/local/include

This should be fixed since it may include unwanted stuff from /usr/local/include.

CC: @vbraun @miguelmarco

Component: packages: optional

Author: Jeroen Demeyer

Branch/Commit: 45d0a5a

Reviewer: Miguel Marco

Issue created by migration from https://trac.sagemath.org/ticket/18573

@jdemeyer jdemeyer added this to the sage-6.8 milestone Jun 1, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Jun 1, 2015

@jdemeyer
Copy link
Author

jdemeyer commented Jun 1, 2015

Commit: 577642b

@jdemeyer
Copy link
Author

jdemeyer commented Jun 1, 2015

New commits:

577642bFix tides build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

45d0a5aFix tides build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2015

Changed commit from 577642b to 45d0a5a

@miguelmarco
Copy link
Contributor

comment:5

Shouldn't it be

$MAKE AM_CPPFLAGS="-I$SAGE_LOCAL/include"

instead of

$MAKE AM_CPPFLAGS="-I $SAGE_LOCAL/include"

?

@jdemeyer
Copy link
Author

comment:6

None of the above :-)

I'm using

$MAKE AM_CPPFLAGS="-I '$SAGE_LOCAL/include'"

Just look at the make logs, the output is correct.

@miguelmarco
Copy link
Contributor

Reviewer: Miguel Marco

@miguelmarco
Copy link
Contributor

comment:7

ok then

@vbraun
Copy link
Member

vbraun commented Jun 24, 2015

Changed branch from u/jdemeyer/fix_build_of_tides_package to 45d0a5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants