Cache rational_diagonal_form()

[jdemeyer]

The diagonalized form is an important starting point for computing invariants, so it should certainly be cached.

Component: quadratic forms

Author: Jeroen Demeyer

Branch/Commit: e995d5e

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/18656

[jdemeyer]

Branch: u/jdemeyer/cache_rational_diagonal_form__

[jdemeyer]

New commits:

2cfad03

Cache rational_diagonal_form()

[jdemeyer]

Commit: 2cfad03

[videlec]

comment:3

Since T is computed each time, why not returning it by default? If you use a cached_method you should minimize the number of arguments.

Also, make the output matrices immutable.

[videlec]

Reviewer: Vincent Delecroix

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8447852	Merge tag '6.9.beta4' into t/18656/cache_rational_diagonal_form__
e995d5e	Solve mutability issues

[sagetrac-git]

Changed commit from 2cfad03 to e995d5e

[jdemeyer]

comment:5

Replying to @videlec:

Since T is computed each time, why not returning it by default? If you use a cached_method you should minimize the number of arguments.

Also, make the output matrices immutable.

Done, I made rational_diagonal_form() a front-end for a cached function _rational_diagonal_form_and_transformation() which returns the form and matrix.

[vbraun]

Changed branch from u/jdemeyer/cache_rational_diagonal_form__ to e995d5e