Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pexpect to SAGERUNTIME #18666

Closed
nathanncohen mannequin opened this issue Jun 10, 2015 · 7 comments
Closed

Add pexpect to SAGERUNTIME #18666

nathanncohen mannequin opened this issue Jun 10, 2015 · 7 comments
Labels
c: build p: blocker / 1 t: bug
Milestone
sage-6.8

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 10, 2015

As reported in sage-devel [1], pexpect should be a dependency of SAGERUNTIME. In #18508, this dependency was accidentally removed.

With this branch, the dependency is made explicit.

Nathann

[1] https://groups.google.com/d/msg/sage-devel/l8rxJjrNWk8/UKX33cqae34J

CC: @vbraun @jdemeyer

Component: build

Author: Nathann Cohen

Branch/Commit: 3058171

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/18666
@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone Jun 10, 2015
@nathanncohen nathanncohen mannequin added c: build labels Jun 10, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 10, 2015

Branch: public/18666

@nathanncohen nathanncohen mannequin added the s: needs review label Jun 10, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2015

Commit: 3058171

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3058171trac #18666: Add pexpect to SAGERUNTIME

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 10, 2015

comment:4

Mystery solved: that happened in #18508, which removed sagenb as a dependency of Sage. That's how pexpect, a dependency of sagenb, was removed as a dependency from SAGERUNTIME.

Nathann

@jdemeyer

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Jun 11, 2015

Changed branch from public/18666 to 3058171

@vbraun vbraun closed this as completed in 52a6091 Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer