Add codim() method for convex cones

[orlitzky]

The dimension of a cone is defined to be the dimension of the span of its generators. It then makes sense to define the codimension as the dimension of the orthogonal complement of that span. This number is equal to the lineality (see trac #18696) of the dual cone.

Depends on #18696

Component: geometry

Author: Michael Orlitzky

Branch/Commit: 0fdb077

Reviewer: Andrey Novoseltsev

Issue created by migration from https://trac.sagemath.org/ticket/18701

[orlitzky]

Commit: 2d1a511

[orlitzky]

Author: Michael Orlitzky

[orlitzky]

Last 10 new commits:

f6faa2b	Trac #18454: Allow random_cone() to be (non-)strictly-convex.
f8e1eb0	Trac #18454: Remove an unnecessary exception in random_cone().
52c148a	Trac #18454: Set max_dim on a random_cone() test that could run forever.
63f92c4	Trac #18454: Add a "solid" parameter to random_cone().
cb7cd15	Trac #18454: Fix warning block formatting in random_cone().
b86adc1	Trac #18454: Catch another infinite loop condition.
3d2151b	Trac #18454: Call set_random_seed() before all random doctests.
1683fd8	Trac #18454: Speed up random_cone() doctests.
227228f	Trac #18696: Add lineality() method for convex cones.
2d1a511	Trac #18701: Add a codim() method for convex cones.

[orlitzky]

Branch: u/mjo/ticket/18701

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d673000

Trac #18701: Add a codim() method for convex cones.

[sagetrac-git]

Changed commit from 2d1a511 to d673000

[orlitzky]

comment:3

That force-push moved the method into the IntegralRayCollection superclass, where I believe it belongs.

[sagetrac-git]

Changed commit from d673000 to 1bb8936

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

deeb2ec	Trac #18454: Allow random_cone() to be (non-)strictly-convex.
44ac645	Trac #18454: Remove an unnecessary exception in random_cone().
909997a	Trac #18454: Set max_dim on a random_cone() test that could run forever.
bd24822	Trac #18454: Add a "solid" parameter to random_cone().
ba66027	Trac #18454: Fix warning block formatting in random_cone().
8b2ff99	Trac #18454: Catch another infinite loop condition.
78c206f	Trac #18454: Call set_random_seed() before all random doctests.
7bdaf1c	Trac #18454: Speed up random_cone() doctests.
473de25	Trac #18696: Add lineality() method for convex cones.
1bb8936	Trac #18701: Add a codim() method for convex cones.

[orlitzky]

comment:5

Testing the new trac server's ability to send email...

[sagetrac-git]

Changed commit from 1bb8936 to 1307fb6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

52a1e4b	Trac #18454: Rename min/max_dim to min/max_ambient_dim in random_cone().
a0235dc	Trac #18454: Fix two confusing random_cone() examples.
5b1eccb	Trac #18454: Remove some excessive doctests for random_cone().
5bf86a6	Trac #18454: Clean up long random_cone() tests.
3e9fd77	Trac #18696: Add lineality() method for convex cones.
1307fb6	Trac #18701: Add a codim() method for convex cones.

[sagetrac-git]

Changed commit from 1307fb6 to 4dbe641

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e6e7a80	Merge branch 't/18613/errors_with_is_isomorphic___for_trivial_cones' into t/18454/ticket/18454
a07efa9	Reviewer's tweaks to random cones.
8c962e1	Trac #18454: Remove more redundant (long) tests.
ed422e3	Trac #18696: Add lineality() method for convex cones.
4dbe641	Trac #18701: Add a codim() method for convex cones.

[novoselt]

Reviewer: Andrey Novoseltsev

[novoselt]

comment:8

Same comments as for #18696 and:

• I'd prefer using "self" to "this collection of rays" in the documentation. That class seemed natural to me as a base of both cones and rays, yet by itself it seems not particularly useful and all doctest examples actually rely on cones. So I think users of cone.codim? will be confused by the mention of a ray collection. If you prefer to avoid "self", perhaps "cone/fan" combination can be used instead?

[sagetrac-git]

Changed commit from 4dbe641 to 0fdb077

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d3eb1c9	Trac #18696: Fix reviewer's suggestions.
6eb8bbd	Trac #18701: Add a codim() method for convex cones.
0fdb077	Trac #18701: Fix reviewer's suggestions.

[orlitzky]

comment:10

Thanks again for your help with these. I had to force-push that last one, not sure why.

[novoselt]

comment:11

Because you had a commit from the previous ticket here: when you rebased on top of it, the current branch here had commits that are now thrown away.

[vbraun]

Changed branch from u/mjo/ticket/18701 to 0fdb077