Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fixed part of build/Makefile to build/deps #18715

Closed
jdemeyer opened this issue Jun 16, 2015 · 7 comments
Closed

Move fixed part of build/Makefile to build/deps #18715

jdemeyer opened this issue Jun 16, 2015 · 7 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-6.8

Comments

@jdemeyer
Copy link

The build rules (not the actual files) for the scripts and extcode targets are "auto-generated" but they are really just one fixed block. Move this to build/deps instead.

Depends on #18533

Component: build

Author: Jeroen Demeyer

Branch/Commit: fa53538

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/18715
@jdemeyer jdemeyer added this to the sage-6.8 milestone Jun 16, 2015
@jdemeyer
Copy link
Author

Dependencies: #18533

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/18715

@jdemeyer
Copy link
Author

Commit: fa53538

@jdemeyer
Copy link
Author

New commits:

d2d009fAdd ccache package
fa53538Move scripts and extcode targets to build/deps

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 17, 2015

comment:4

Looks good too.

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 17, 2015

Reviewer: Nathann Cohen

@vbraun
Copy link
Member

vbraun commented Jun 18, 2015

Changed branch from u/jdemeyer/ticket/18715 to fa53538

@vbraun vbraun closed this as completed in cece6ce Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer