Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serious bug in pickling elliptic curves #1872

Closed
williamstein opened this issue Jan 20, 2008 · 3 comments
Closed

serious bug in pickling elliptic curves #1872

williamstein opened this issue Jan 20, 2008 · 3 comments

Comments

@williamstein
Copy link
Contributor

sage: E = EllipticCurve('185c1')
sage: E.gens()
[(-5/4 : 3/8 : 1)]
sage: loads(dumps(E))
---------------------------------------------------------------------------
<type 'exceptions.AttributeError'>        Traceback (most recent call last)

/Users/was/papers/bsdalg/newdata/heegner_index_rank1/data/<ipython console> in <module>()

/Users/was/papers/bsdalg/newdata/heegner_index_rank1/data/sage_object.pyx in sage.structure.sage_object.loads()

/Users/was/papers/bsdalg/newdata/heegner_index_rank1/data/sage_object.pyx in sage.structure.sage_object.loads()

/Users/was/s/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_point.py in make_point(X, v)
    648     # It looks like there's generic code to do this, but it's been commented out. 
    649     #
    650     # Here we create a new (equivalent) parent manually. 
--> 651     del X._Scheme__ring_point_homset
    652     return EllipticCurvePoint_field(X, v)

<type 'str'>: (<type 'exceptions.AttributeError'>, AttributeError("'EllipticCurve_rational_field' object has no attribute '_EllipticCurve_generic__ainvs'",))

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/1872

@williamstein
Copy link
Contributor Author

Attachment: trac-1872.patch.gz

this fixes the problem

@williamstein
Copy link
Contributor Author

comment:1

The patch simply deletes some functions, deletes some commented out code, and names a variable something meaningful instead of meaningless.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 21, 2008

comment:3

Merged in Sage 2.10.1.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 21, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants