Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up number_field/maps.py #18727

Closed
pjbruin opened this issue Jun 18, 2015 · 5 comments
Closed

Clean up number_field/maps.py #18727

pjbruin opened this issue Jun 18, 2015 · 5 comments
Labels
c: number fields p: minor / 4 t: enhancement
Milestone
sage-6.8

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Jun 18, 2015

The goal of this ticket is to clean up of the code in sage/rings/number_field/maps.py, which contains several unnecessary attributes and conversions. One motivation for this is to simplify work on #252.

There are no changes in functionality. The total running time of the doctests in sage/rings/number_field does not increase and even appears to decrease slightly.

Component: number fields

Author: Peter Bruin

Branch/Commit: 195d3d2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/18727
@pjbruin pjbruin added this to the sage-6.8 milestone Jun 18, 2015
@pjbruin
Copy link
Contributor Author

pjbruin commented Jun 18, 2015

Branch: u/pbruin/18727-number_field_maps_cleanup

@pjbruin
Copy link
Contributor Author

pjbruin commented Jun 18, 2015

Commit: 195d3d2

@tscrim
Copy link
Collaborator

tscrim commented Jun 18, 2015

comment:2

It is possibly a bit faster because the cython function calls are faster than the python attribute calls? Anyways, LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 18, 2015

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 20, 2015

Changed branch from u/pbruin/18727-number_field_maps_cleanup to 195d3d2

@vbraun vbraun closed this as completed in 89219fd Jun 20, 2015
@pjbruin pjbruin mentioned this issue Aug 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @pjbruin