Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for invalid algorithm in obtain_nash #18729

Closed
theref mannequin opened this issue Jun 18, 2015 · 3 comments
Closed

Raise error for invalid algorithm in obtain_nash #18729

theref mannequin opened this issue Jun 18, 2015 · 3 comments
Labels
c: game theory r: duplicate t: bug

Comments

@theref
Copy link
Mannequin

theref mannequin commented Jun 18, 2015

Currently if someone were to do:

sage: A = matrix([[1, 1, 5], [2, 2, 0]])
sage: g = NormalFormGame([A])
sage: g.obtain_nash(algorithm='garbage')

sage just returns with no error raised.
correct output should be:

sage: g.obtain_nash(algorithm='garbage')
Traceback (most recent call last):
...
ValueError: garbage is not a valid algorithm.

CC: @drvinceknight

Component: game theory

Keywords: Normal Form Game, Error

Reviewer: James Campbell, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/18729
@theref theref mannequin added this to the sage-6.8 milestone Jun 18, 2015
@theref theref mannequin added c: game theory labels Jun 18, 2015
@theref
Copy link
Mannequin Author

theref mannequin commented Jun 22, 2015

comment:1

This issue has already been resolved within #18536.

@theref theref mannequin removed this from the sage-6.8 milestone Jun 22, 2015
@theref theref mannequin added the s: needs review label Jun 22, 2015
@kcrisman
Copy link
Member

Reviewer: James Campbell, Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:3

This issue has already been resolved within #18536.

Correct.

@vbraun vbraun closed this as completed Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: game theory r: duplicate t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbraun @kcrisman