Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DejterGraph, F26AGraph, HarborthGraph, Klein3RegularGraph, Klein7RegularGraph, LocalMcLaughlinGraph #18782

Closed
nathanncohen mannequin opened this issue Jun 24, 2015 · 14 comments
Closed

DejterGraph, F26AGraph, HarborthGraph, Klein3RegularGraph, Klein7RegularGraph, LocalMcLaughlinGraph #18782

nathanncohen mannequin opened this issue Jun 24, 2015 · 14 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-6.8

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 24, 2015

This branch adds the following graph constructors:

DejterGraph
!F26AGraph
HarborthGraph
Klein3RegularGraph
Klein7RegularGraph
LocalMcLaughlinGraph

Nathann

CC: @videlec @dimpase @fchapoton

Component: graph theory

Author: Nathann Cohen

Branch: 39cd4eb

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/18782
@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone Jun 24, 2015
@nathanncohen

This comment has been minimized.

Sign in to view
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 24, 2015

Branch: public/18782

@nathanncohen nathanncohen mannequin added the s: needs review label Jun 24, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d7fb7b4trac #18782: DejterGraph, F26AGraph, HarborthGraph, Klein3RegularGraph, Klein7RegularGraph, LocalMcLaughlinGraph

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2015

Commit: d7fb7b4

@fchapoton
Copy link
Contributor

comment:3

missing # optional gap_packages

for the LocalMcLaughlinGraph

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2015

Changed commit from d7fb7b4 to 39cd4eb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

101b516trac #18782: Merged with 6.8.beta6
39cd4ebtrac #18782: Add 'optional' tag

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 28, 2015

comment:5

missing # optional gap_packages

for the LocalMcLaughlinGraph

Sorry. Fixed.

Nathann

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:6

Hello,

I have tried the patch before and after installing gap_packages and it is working properly (install, doc, tests).

David.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 13, 2015

comment:7

Thaaaaaaaaaaaaaaaaaaaaaaaaaanks !!!!

Nathann

@vbraun
Copy link
Member

vbraun commented Jul 14, 2015

Changed branch from public/18782 to 39cd4eb

@vbraun vbraun closed this as completed in ebfaf96 Jul 14, 2015
@jdemeyer
Copy link

comment:9

Breakage: #18911

@jdemeyer
Copy link

Changed commit from 39cd4eb to none

@jdemeyer jdemeyer mentioned this issue Jul 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
4 participants
@vbraun @jdemeyer @fchapoton @dcoudert