Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 preparation: Change syntax of raise with traceback #18799

Closed
wluebbe mannequin opened this issue Jun 27, 2015 · 8 comments
Closed

Python 3 preparation: Change syntax of raise with traceback #18799

wluebbe mannequin opened this issue Jun 27, 2015 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-6.10

Comments

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented Jun 27, 2015

2to3 proposes changes for

raise E, V, T -> raise E(V).with_traceback(T)
raise E, None, T -> raise E.with_traceback(T)

These changes are invalid (see also #18796).

Several options are given in the documentation of python-future (see http://python-future.org/compatible_idioms.html#raising-exceptions).

This ticket is tracked as a dependency of meta-ticket #16052.
The simple raise statements are fixed in #15990.

Component: misc

Author: Wilfried Luebbe

Branch/Commit: 249b939

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18799
@wluebbe wluebbe mannequin added this to the sage-6.8 milestone Jun 27, 2015
@wluebbe wluebbe mannequin added p: major / 3 labels Jun 27, 2015
@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Jun 27, 2015

Branch: u/wluebbe/18799

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Jun 27, 2015

Commit: 249b939

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Jun 27, 2015

Author: Wilfried Luebbe

@wluebbe
Copy link
Mannequin Author

wluebbe mannequin commented Jun 27, 2015

New commits:

249b939Trac #18799: Change syntax of raise with traceback

@wluebbe wluebbe mannequin added the s: needs review label Jun 27, 2015
@fchapoton
Copy link
Contributor

comment:2

I propose to convert the elliptic curve one to a simple raise (no traceback)

@fchapoton
Copy link
Contributor

comment:3

ok, let it be.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton fchapoton modified the milestones: sage-6.8, sage-6.10 Oct 18, 2015
@vbraun
Copy link
Member

vbraun commented Oct 18, 2015

Changed branch from u/wluebbe/18799 to 249b939

@vbraun vbraun closed this as completed in 7ade658 Oct 18, 2015
@wluebbe wluebbe mannequin mentioned this issue Aug 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.10
Development

No branches or pull requests
2 participants
@vbraun @fchapoton