Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a method in ClusterSeed for presenting the upper bound algebra #18800

Closed
sagetrac-jmatherne mannequin opened this issue Jun 28, 2015 · 18 comments
Closed

Implement a method in ClusterSeed for presenting the upper bound algebra #18800

sagetrac-jmatherne mannequin opened this issue Jun 28, 2015 · 18 comments

Comments

@sagetrac-jmatherne
Copy link
Mannequin

sagetrac-jmatherne mannequin commented Jun 28, 2015

Adds a find_upper_bound method to ClusterSeed. This method implements the algorithm in !arXiv:1307.0579 for giving a presentation of the upper bound algebra in terms of generators and relations.

It inputs a ClusterSeed and outputs the upper bound algebra as a quotient_ring.

CC: @Etn40ff @sagetrac-gmoose05 @egunawan @thecaligarmo

Component: combinatorics

Keywords: cluster, SageDays64.5, upper bound

Author: Jacob P. Matherne, Matthew R. Mills, Greg Muller, Harold Williams

Branch/Commit: 3676fd5

Reviewer: Gregg Musiker

Issue created by migration from https://trac.sagemath.org/ticket/18800

@sagetrac-jmatherne sagetrac-jmatherne mannequin added this to the sage-6.8 milestone Jun 28, 2015
@sagetrac-jmatherne

This comment has been minimized.

@sagetrac-jmatherne
Copy link
Mannequin Author

sagetrac-jmatherne mannequin commented Jun 28, 2015

comment:1

Attachment: cluster_seed.py.gz

@sagetrac-jmatherne

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:6

you need to provide a git branch, not an attachment

@fchapoton
Copy link
Contributor

Branch: public/ticket/18800

@fchapoton
Copy link
Contributor

comment:7

I have made a git branch for you, and cleaned-up the code.


New commits:

7321de5trac #18800 upper bounds of cluster algebras
070c916trac #18800 clean-up and simplifications

@fchapoton
Copy link
Contributor

Commit: 070c916

@sagetrac-jmatherne
Copy link
Mannequin Author

sagetrac-jmatherne mannequin commented Sep 12, 2015

comment:9

Thank you for all the work and help. It is much appreciated! The code is a lot cleaner now.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 31, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

8703225Merge branch 'public/ticket/18800' into 6.10.beta2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 31, 2015

Changed commit from 070c916 to 8703225

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

bef8211Merge branch 'public/ticket/18800' into 7.3.b4
ea2233atrac 18800 py3 print

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2016

Changed commit from 8703225 to ea2233a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

3676fd5Merge branch 'public/ticket/18800' of git://trac.sagemath.org/sage into public/ticket/18800

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2016

Changed commit from ea2233a to 3676fd5

@fchapoton
Copy link
Contributor

comment:15

bot is green. That would be a good time for a review.

@fchapoton fchapoton modified the milestones: sage-6.9, sage-7.4 Aug 5, 2016
@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Aug 8, 2016

comment:16

Computations seem to behave as I expected. Since the bot is green, I think we're good to go.

@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Aug 8, 2016

Reviewer: Gregg Musiker

@vbraun
Copy link
Member

vbraun commented Aug 13, 2016

Changed branch from public/ticket/18800 to 3676fd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants