New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hint in the automatic doctest sig_on_count() #18829
Comments
Commit: |
New commits:
|
Branch: u/ncohen/18829 |
comment:2
Shouldn't you set this patch to I assume than for testing it we have no choice but doctesting the full |
comment:3
Agggggg, I am an idiot. I had started all tests when I created the branch, and this morning I closed a remote ssh session without knowing what it had been testing. It was probably this patch. I'll re-run the tests |
comment:6
Can you just define a string constant for
instead of writing the same string several times. |
comment:7
Done ! For this kind of trivial changes, it is not too daring for a reviewer to propose a commit Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Jeroen Demeyer |
Changed branch from u/ncohen/18829 to |
While working on #18746, I met a doctest error for a doctest that never appeared in my file. I looked at it for a while before undersdtanding what was happening. This branch adds the 'hint' I needed at that time.
Nathann
CC: @dcoudert
Component: doctest framework
Author: Nathann Cohen
Branch/Commit:
2e666dd
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/18829
The text was updated successfully, but these errors were encountered: