Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hint in the automatic doctest sig_on_count() #18829

Closed
nathanncohen mannequin opened this issue Jun 30, 2015 · 13 comments
Closed

Add a hint in the automatic doctest sig_on_count() #18829

nathanncohen mannequin opened this issue Jun 30, 2015 · 13 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jun 30, 2015

While working on #18746, I met a doctest error for a doctest that never appeared in my file. I looked at it for a while before undersdtanding what was happening. This branch adds the 'hint' I needed at that time.

Nathann

CC: @dcoudert

Component: doctest framework

Author: Nathann Cohen

Branch/Commit: 2e666dd

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/18829

@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone Jun 30, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 30, 2015

Commit: b70e19e

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 30, 2015

New commits:

b70e19etrac #18829: Add a hint in the automatic doctest sig_on_count()

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jun 30, 2015

Branch: u/ncohen/18829

@dcoudert
Copy link
Contributor

dcoudert commented Jul 3, 2015

comment:2

Shouldn't you set this patch to needs review?

I assume than for testing it we have no choice but doctesting the full src/sage/ directory. Right?

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 3, 2015

comment:3

Agggggg, I am an idiot. I had started all tests when I created the branch, and this morning I closed a remote ssh session without knowing what it had been testing. It was probably this patch. I'll re-run the tests T_T

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

ca2980ftrac #18829: Merged with 6.8.beta7
d42c0a4trac #18829: Broken doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2015

Changed commit from b70e19e to d42c0a4

@nathanncohen nathanncohen mannequin added the s: needs review label Jul 3, 2015
@jdemeyer
Copy link

jdemeyer commented Jul 4, 2015

comment:6

Can you just define a string constant for

"sig_on_count() # check sig_on/off pairings (virtual doctest)\n"

instead of writing the same string several times.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 4, 2015

comment:7

Done !

For this kind of trivial changes, it is not too daring for a reviewer to propose a commit ^^;

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

2e666ddtrac #18829: One string to rule them all

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2015

Changed commit from d42c0a4 to 2e666dd

@jdemeyer
Copy link

jdemeyer commented Jul 5, 2015

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jul 5, 2015

Changed branch from u/ncohen/18829 to 2e666dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants