Really fix cleaning of Sage library

[jdemeyer]

Since #18494, we install .pxd files but we never remove them.

CC: @kiwifb @nathanncohen

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 2b0fbaf

Reviewer: Steven Trogdon

Issue created by migration from https://trac.sagemath.org/ticket/18842

[strogdon]

comment:2

Here a

rm local/lib/python2.7/site-packages/sage/graphs/graph_decompositions/*.pxd

seemed to allow one to recover, but then required a make doc-clean && make to rebuild the docs.

[strogdon]

comment:3

Actually, only fast_digraph.pxd and vertex_separation.pxd have to be removed which are new with ticket #18746.

[jdemeyer]

Branch: u/jdemeyer/cythonization_broken

[jdemeyer]

New commits:

2b0fbaf

Consider all installed files for cleaning up

[jdemeyer]

Commit: 2b0fbaf

[kiwifb]

comment:6

So i see you are switching to only using data_files and the only headers to be considered are those found in SAGE_CYTHONIZED which makes sense as all the useful headers will be copied.

Is the issue only happening when one does an upgrade or a re-build where as your commit suggest we may have obsolete .pxd, .pyx or .h files being kept while they should have been deleted?

[jdemeyer]

comment:7

Hmm... the basic idea of my commit works, but the problem is the order: this cleaning needs to be done before cythonization.

[jdemeyer]

comment:8

Replying to @kiwifb:

Is the issue only happening when one does an upgrade or a re-build where as your commit suggest we may have obsolete .pxd, .pyx or .h files being kept while they should have been deleted?

Yes, if we delete a .pxd file from the sources, it should also be deleted from the installation directory.

[jdemeyer]

Upstream: Reported upstream. No feedback yet.

[strogdon]

comment:10

Replying to @jdemeyer:

Hmm... the basic idea of my commit works, but the problem is the order: this cleaning needs to be done before cythonization.

Bummer. You're absolutely correct. And this is what is done when they are removed manually.

[jdemeyer]

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

[jdemeyer]

Changed upstream from Reported upstream. Developers acknowledge bug. to none

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

comment:12

See #18851 for the Cython patch.

This branch is still relevant, but it doesn't fix the problem originally reported.

[strogdon]

Reviewer: Steven Trogdon

[strogdon]

comment:13

Built Sage on top of 6.8.beta6 with commits from this ticket and #18851 + #18746. All .pxd files added with #18746 were removed when Sage was rebuild without #18746. François, feel free to reverse things if you see anything out of place with the commits.

[kiwifb]

comment:14

It's absolutely fine with me and definitely should go in.

[vbraun]

Changed branch from u/jdemeyer/cythonization_broken to 2b0fbaf