Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pari workarond for Perl regex deprecation #18872

Closed
vbraun opened this issue Jul 8, 2015 · 22 comments
Closed

Pari workarond for Perl regex deprecation #18872

vbraun opened this issue Jul 8, 2015 · 22 comments

Comments

@vbraun
Copy link
Member

vbraun commented Jul 8, 2015

Perl 5.21.1 throws warnings for unescaped '{', and pari treats warnings as errors by default. Patch taken from

https://projects.archlinux.org/svntogit/community.git/tree/trunk/no_warnings_fatal.patch?h=packages/pari-sage

Upstream report: http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1726

Upstream: Workaround found; Bug reported upstream.

CC: @jdemeyer

Component: packages: standard

Author: Volker Braun, Jeroen Demeyer

Branch/Commit: 91665e9

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/18872

@vbraun vbraun added this to the sage-6.8 milestone Jul 8, 2015
@vbraun
Copy link
Member Author

vbraun commented Jul 8, 2015

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Jul 8, 2015

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Jul 8, 2015

Changed branch from u/vbraun/pari_workarond_for_perl_regex_deprecation to none

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

comment:5

From the sage-devel report, it seems that the problem is in the gphelp script, not in doc_make (I'm not saying they are not related, but at least this fix might not be sufficient).

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

Commit: eaa8ab6

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

New commits:

eaa8ab6Pari workarond for Perl regex deprecation

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

Reviewer: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

Upstream: Reported upstream. No feedback yet.

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2015

comment:9

This patch works (although it gives 11152 deprecation warnings when auto-generating the PARI functions), but I'd rather wait a bit to give upstream a chance to fix this in a proper way.

However, if you need to release Sage 6.8 very soon, you can merge this right away.

@jdemeyer
Copy link

Changed branch from u/vbraun/pari_workarond_for_perl_regex_deprecation to none

@jdemeyer
Copy link

Changed upstream from Reported upstream. No feedback yet. to Workaround found; Bug reported upstream.

@jdemeyer
Copy link

Changed author from Volker Braun to Volker Braun, Jeroen Demeyer

@jdemeyer
Copy link

Changed commit from eaa8ab6 to none

@jdemeyer
Copy link

Changed reviewer from Jeroen Demeyer to none

@jdemeyer
Copy link

@jdemeyer
Copy link

comment:12

Applied upstream fix instead.


New commits:

91665e9Fix PARI with Perl 5.22

@jdemeyer
Copy link

Commit: 91665e9

@vbraun
Copy link
Member Author

vbraun commented Jul 14, 2015

Reviewer: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Jul 15, 2015

Changed branch from u/jdemeyer/pari_workarond_for_perl_regex_deprecation to 91665e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants