Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Pynac for some symbolic comparisons instead of Maxima #18883

Open
rwst opened this issue Jul 12, 2015 · 19 comments
Open

use Pynac for some symbolic comparisons instead of Maxima #18883

rwst opened this issue Jul 12, 2015 · 19 comments

Comments

@rwst
Copy link

rwst commented Jul 12, 2015

This:

sage: bool(exp(x)>=0)
True

unexpectedly uses Maxima, and gets it wrong, too (the already known complex domain problem, see e.g. #14305).

Since Pynac can now assign info flags to function expressions the possible cases for abs, factorial, binomial, real, imag, step should be implemented in Pynac (this is pynac/pynac#78) and the cases like above handled in Pynac.

The repercussions are not limited to such comparisons. The more expressions have info flags set the more expressions with more complicated structure can be decided and more questions answered.

Depends on #22219

Component: symbolics

Author: Ralf Stephan

Branch/Commit: u/rws/use_pynac_for_some_symbolic_comparisons_instead_of_maxima @ 18c2768

Issue created by migration from https://trac.sagemath.org/ticket/18883

@rwst rwst added this to the sage-6.8 milestone Jul 12, 2015
@rwst
Copy link
Author

rwst commented Jul 19, 2015

comment:1

Turns out that, additionally, an explicit nonzero info flag is needed in Pynac because without a nonzero flag the above test in the reals is always delegated to Maxima, as well. pynac/pynac#79

EDIT: remove nonsense

@rwst rwst changed the title use Pynac for symbolic comparison instead of Maxima use Pynac for some symbolic comparisons instead of Maxima Jul 20, 2015
@rwst
Copy link
Author

rwst commented Jul 21, 2015

Branch: pynac-0.4.3

@rwst
Copy link
Author

rwst commented Jul 21, 2015

Upstream: Fixed upstream, in a later stable release.

@fchapoton
Copy link
Contributor

comment:4

pynac-0.4.3 is not a git branch

@fchapoton
Copy link
Contributor

Changed branch from pynac-0.4.3 to none

@rwst
Copy link
Author

rwst commented Jul 12, 2016

comment:5

This was NOT fixed as claimed in the ticket field.

@rwst
Copy link
Author

rwst commented Jul 12, 2016

Changed upstream from Fixed upstream, in a later stable release. to Reported upstream. Developers acknowledge bug.

@rwst
Copy link
Author

rwst commented Jan 19, 2017

@rwst
Copy link
Author

rwst commented Jan 19, 2017

Commit: 5abe68e

@rwst
Copy link
Author

rwst commented Jan 19, 2017

comment:7

This commit enables all Pynac relational logic improvements and only falls back on Maxima if Pynac returns Not Implemented.


New commits:

5abe68e18883: take advantage of more fine-grained logic results from Pynac

@rwst
Copy link
Author

rwst commented Jan 19, 2017

Dependencies: pynac-0.7.4

@rwst
Copy link
Author

rwst commented Jan 19, 2017

comment:8

To fix the Maxima-related problem, as a solution to the complex/real domain issue is not expected it might be possible to use only Pynac with relations, and use both with equality questions.

@rwst
Copy link
Author

rwst commented Jan 19, 2017

comment:9

If Pynac should take over all questions on relations then it must be able to also answer this:

            sage: (x > 2).assume()
            sage: bool(x > 0)
            True

because it's impossible do separate domain-only questions from more general ones. That means the workaround mentioned in comment:8 depends on pynac/pynac#227

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2017

Changed commit from 5abe68e to 18c2768

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 20, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

18c276818883: depend on Pynac handling all inequalities

@rwst
Copy link
Author

rwst commented Feb 8, 2017

Changed upstream from Reported upstream. Developers acknowledge bug. to none

@rwst
Copy link
Author

rwst commented Feb 8, 2017

Changed dependencies from pynac-0.7.4 to #22219

@rwst rwst modified the milestones: sage-6.8, sage-7.6 Feb 8, 2017
@rwst
Copy link
Author

rwst commented Dec 26, 2017

Author: Ralf Stephan

@rwst rwst modified the milestones: sage-7.6, sage-8.2 Dec 26, 2017
@rwst
Copy link
Author

rwst commented Mar 3, 2018

comment:14

Lots of doctest errors. Back to the drawing board.

@mkoeppe mkoeppe removed this from the sage-8.2 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants