Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for general c_{ij} for Nakajima monomials and some cleanup #18895

Closed
tscrim opened this issue Jul 14, 2015 · 23 comments
Closed

Add support for general c_{ij} for Nakajima monomials and some cleanup #18895

tscrim opened this issue Jul 14, 2015 · 23 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Jul 14, 2015

The definition allows a choice of a general cij matrix such that cij + cji = 1 for all i != j.

We also perform some cleanup:

  • Remove the trailing whitespace at the end of the monomial printing.
  • Only needing to input the dominant weight.
  • Better handling of dictionaries in monomial methods.

CC: @sagetrac-sage-combinat @bsalisbury1

Component: combinatorics

Keywords: crystals, nakajima monomials

Author: Travis Scrimshaw

Branch/Commit: 5da5f89

Reviewer: Ben Salisbury

Issue created by migration from https://trac.sagemath.org/ticket/18895

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 4, 2016

comment:1

I am recycling this ticket because I couldn't improve the weight function.


New commits:

aab22d3Adding support for general c_{ij} and some cleanup.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 4, 2016

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 4, 2016

Commit: aab22d3

@tscrim tscrim changed the title Cleanup for monomial crystals Add support for general c_{ij} for Nakajima monomials and some cleanup Apr 4, 2016
@tscrim tscrim modified the milestones: sage-6.8, sage-7.2 Apr 4, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2016

Changed commit from aab22d3 to 2ef42bc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

2ef42bcNeeding to do a transpose and adding an extra input check.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Changed commit from 2ef42bc to 825bf35

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

53891f2Added some more documentation and input checking.
825bf35Making the choice of monomial a global option.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b87cc0aMerge branch 'develop' into public/crystals/general_c_monomial-18895
fd09f2aSome last little fixes for the global_options option.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2016

Changed commit from 825bf35 to fd09f2a

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 10, 2016

Changed commit from fd09f2a to 58ffd2c

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 10, 2016

comment:5

Variant which uses an instance option rather than global option for setting the display output.


New commits:

58ffd2cA variant using an instance option.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 10, 2016

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2016

Changed commit from 58ffd2c to fd4af09

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

4b7a2a4Merge branch 'public/crystals/general_c_monomial-18895' of git://trac.sagemath.org/sage into monomials
b8ed79dMerge branch 'public/crystals/general_c_monomial_v2-18895' of git://trac.sagemath.org/sage into monomials
3c2fa2bMerge branch 'develop' into monomials
fd4af09documentation fixes and changed _monomial to _variable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2016

Changed commit from fd4af09 to e010047

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e010047fixed doctest error

@bsalisbury1
Copy link

comment:8

Hey Travis,

Thanks for doing this! I made a bunch of documentation fixes and improvements. Also, I changed ._monomial, .get_monomials, and .set_monomials to _.variable, .get_variables, and .set_variables, respectively. If you agree with these changes, then it can get a positive review from me.

@bsalisbury1
Copy link

Reviewer: Ben Salisbury

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2016

Changed commit from e010047 to 5da5f89

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 15, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

5da5f89Fixing the handling of (deprecated) use_Y.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 15, 2016

comment:10

I noticed that we aren't properly using the use_Y, and I fixed that on my last commit. I'm okay with your changes. So if you agree with mine, then it is a positive review.

@vbraun
Copy link
Member

vbraun commented Apr 16, 2016

Changed branch from public/crystals/general_c_monomial_v2-18895 to 5da5f89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants