Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a -fix-pkg-checksums argument to sage #18947

Closed
nathanncohen mannequin opened this issue Jul 24, 2015 · 9 comments
Closed

Add a -fix-pkg-checksums argument to sage #18947

nathanncohen mannequin opened this issue Jul 24, 2015 · 9 comments
Labels
c: scripts p: major / 3 t: bug
Milestone
sage-6.8

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 24, 2015

The 'sage-fix-pkg-checksums' utility is not (yet) available as an option of 'sage'. This branch fixes it.

Nathann

Component: scripts

Author: Nathann Cohen

Branch/Commit: bd1d6eb

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/18947
@nathanncohen nathanncohen mannequin added this to the sage-6.8 milestone Jul 24, 2015
@nathanncohen nathanncohen mannequin added c: scripts labels Jul 24, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 24, 2015

New commits:

dbd6c1atrac #18947: Add a -fix-pkg-checksums argument to sage

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 24, 2015

Branch: u/ncohen/18947

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 24, 2015

Commit: dbd6c1a

@nathanncohen nathanncohen mannequin added the s: needs review label Jul 24, 2015
@seblabbe
Copy link
Contributor

Changed branch from u/ncohen/18947 to public/18947

@seblabbe
Copy link
Contributor

comment:2

Good idea. Since fixing the checksums belongs more to the "creation" of packages than to the "installation" of packages, I moved that option into the section Making Sage packages or distributions: of sage -advanced.

I let you review my commit (I agree with yours).

New commits:

bd1d6ebTrac #18947: Move -fix-pkg-checksums in making packages section of sage -advanced

@seblabbe
Copy link
Contributor

Changed commit from dbd6c1a to bd1d6eb

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 26, 2015

comment:3

Good idea, thanks!

Nathann

@vbraun
Copy link
Member

vbraun commented Jul 27, 2015

Changed branch from public/18947 to bd1d6eb

@vbraun vbraun closed this as completed in a499206 Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
2 participants
@vbraun @seblabbe