Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a doc typo in graph.py #18949

Closed
fchapoton opened this issue Jul 24, 2015 · 8 comments
Closed

a doc typo in graph.py #18949

fchapoton opened this issue Jul 24, 2015 · 8 comments

Comments

@fchapoton
Copy link
Contributor

let us correct that typo

CC: @nathanncohen

Component: graph theory

Author: Frédéric Chapoton

Branch/Commit: 3b9cb9c

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/18949

@fchapoton fchapoton added this to the sage-6.8 milestone Jul 24, 2015
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/18949

@fchapoton
Copy link
Contributor Author

New commits:

3b9cb9cjust a few details in graph.py

@fchapoton
Copy link
Contributor Author

Commit: 3b9cb9c

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 24, 2015

comment:2

Thanks !

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 24, 2015

Reviewer: Nathann Cohen

@wluebbe
Copy link
Mannequin

wluebbe mannequin commented Jul 26, 2015

comment:3

Maybe this citation from PEP 8 (https://www.python.org/dev/peps/pep-0008/) applies:

Don't compare boolean values to True or False using  ==  . 
Yes:   if greeting:
No:    if greeting == True:
Worse: if greeting is True:

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 26, 2015

comment:4

Maybe this citation from PEP 8 (https://www.python.org/dev/peps/pep-0008/) applies:

You can set the ticket to needs_work if you want.

Nathann

@vbraun
Copy link
Member

vbraun commented Jul 27, 2015

Changed branch from u/chapoton/18949 to 3b9cb9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants