New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better subs method for matrices #19045
Comments
Branch: u/vdelecroix/19045 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Reviewer: Nathann Cohen |
comment:3
Looks good. What about 'does on coefficient': isn't a 's' missing there? Otherwise it's good. Regardless of what you choose to do with this, you can set the ticket to Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Thanks Nathann. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:9
The current situation is not homogeneous:
This is probably due to a problem in the substitution at the polynomial level. Also, the parent of the result should be determined by the parent of the matrix and the parent of the substitued values, not only the entries of the result, or it will be unpredictable. |
Changed reviewer from Nathann Cohen to Nathann Cohen, Thierry Monteil |
comment:10
Even worse:
|
comment:11
Replying to @sagetrac-tmonteil:
It is. And then indepent of this ticket.
The above subs is clearly broken and you are welcome to fix it. The method
I do not see what I can do better for the sake of this ticket. This is not clear enough to me what I should do. Perhaps opening a ticket "give specifications for subs and include it in the coercion model"? |
comment:12
I'm setting this back to Nathann |
Changed branch from u/vdelecroix/19045 to |
Changed commit from |
comment:14
|
comment:15
Replying to @sagetrac-tmonteil:
Yes
This is not a dependency. But I opened #19130.
not merging ticket is also a good way to not fix it ;-) |
As mentioned on this sage-devel thread the
.subs()
method of matrices behaves badly with polynomials.Component: linear algebra
Author: Vincent Delecroix
Branch:
59990af
Reviewer: Nathann Cohen, Thierry Monteil
Issue created by migration from https://trac.sagemath.org/ticket/19045
The text was updated successfully, but these errors were encountered: