Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reimplementing matrix_integer_dense using FLINT #19081

Closed
sagetrac-kartikv mannequin opened this issue Aug 24, 2015 · 13 comments
Closed

More reimplementing matrix_integer_dense using FLINT #19081

sagetrac-kartikv mannequin opened this issue Aug 24, 2015 · 13 comments

Comments

@sagetrac-kartikv
Copy link
Mannequin

sagetrac-kartikv mannequin commented Aug 24, 2015

Now with hermite normal forms. Added a new algorithm choice ("flint") to hermite form, and updated cutoffs to account for the fact that pari0 generally beats flint < 125 rows/cols and FLINT wins above that. pari1 and pari4 seem to always be much worse, as is ntl and the built-in padic method, but I only tested up to matrices of a few hundred entries. Also, flint does better for smaller matrices with larger entries, so that should be accounted for as well, but this is a reasonable first pass.

CC: @vbraun

Component: linear algebra

Keywords: matrix, dense

Author: Kartik Venkatram

Branch/Commit: e7fe591

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/19081

@sagetrac-kartikv sagetrac-kartikv mannequin added this to the sage-6.9 milestone Aug 24, 2015
@sagetrac-kartikv
Copy link
Mannequin Author

sagetrac-kartikv mannequin commented Aug 24, 2015

Author: Kartik Venkatram

@sagetrac-kartikv
Copy link
Mannequin Author

sagetrac-kartikv mannequin commented Aug 24, 2015

Branch: u/kartikv/19081_flint_hnf

@sagetrac-kartikv
Copy link
Mannequin Author

sagetrac-kartikv mannequin commented Aug 24, 2015

Commit: 4165319

@sagetrac-kartikv
Copy link
Mannequin Author

sagetrac-kartikv mannequin commented Aug 24, 2015

New commits:

4165319adding flint as an option for HNF and using it as the default for moderately large matrices

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Changed commit from 4165319 to f11bdf3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

f11bdf3now with correctly sized transformation matrices

@ohanar
Copy link
Member

ohanar commented Aug 24, 2015

Changed reviewer from vbraun to R. Andrew Ohana

@ohanar
Copy link
Member

ohanar commented Aug 24, 2015

comment:3

The description of the default algorithm doesn't match the code.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Changed commit from f11bdf3 to e7fe591

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

e7fe591corrected comment

@sagetrac-kartikv
Copy link
Mannequin Author

sagetrac-kartikv mannequin commented Aug 24, 2015

comment:5

Sorry about that, too much undoing. Should be right now.

@ohanar
Copy link
Member

ohanar commented Aug 24, 2015

comment:6

looks good to me

@vbraun
Copy link
Member

vbraun commented Aug 26, 2015

Changed branch from u/kartikv/19081_flint_hnf to e7fe591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants