New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More reimplementing matrix_integer_dense using FLINT #19081
Comments
Author: Kartik Venkatram |
Branch: u/kartikv/19081_flint_hnf |
Commit: |
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed reviewer from vbraun to R. Andrew Ohana |
comment:3
The description of the default algorithm doesn't match the code. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Sorry about that, too much undoing. Should be right now. |
comment:6
looks good to me |
Changed branch from u/kartikv/19081_flint_hnf to |
Now with hermite normal forms. Added a new algorithm choice ("flint") to hermite form, and updated cutoffs to account for the fact that pari0 generally beats flint < 125 rows/cols and FLINT wins above that. pari1 and pari4 seem to always be much worse, as is ntl and the built-in padic method, but I only tested up to matrices of a few hundred entries. Also, flint does better for smaller matrices with larger entries, so that should be accounted for as well, but this is a reasonable first pass.
CC: @vbraun
Component: linear algebra
Keywords: matrix, dense
Author: Kartik Venkatram
Branch/Commit:
e7fe591
Reviewer: R. Andrew Ohana
Issue created by migration from https://trac.sagemath.org/ticket/19081
The text was updated successfully, but these errors were encountered: