freetype 2.6 fails to build on scientific linux 7.1

[kiwifb]

Building freetype fails with:

/autofit.lo /home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/autofit.c
libtool: compile:  gcc -pedantic -ansi -I/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit -I/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/objs -I./builds/unix -I/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/include -c -Wall -g -O2 -I/home/frb15/sagemath/sage-brial/local/include -DFT_CONFIG_OPTION_SYSTEM_ZLIB -I/home/frb15/sagemath/sage-brial/local/include -DFT_CONFIG_OPTION_USE_BZIP2 -I/home/frb15/sagemath/sage-brial/local/include/libpng12 -DFT_CONFIG_OPTION_USE_PNG -I/usr/include/harfbuzz -DFT_CONFIG_OPTION_USE_HARFBUZZ "-DFT_CONFIG_CONFIG_H=<ftconfig.h>" -DFT2_BUILD_LIBRARY "-DFT_CONFIG_MODULES_H=<ftmodule.h>" /home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/autofit.c  -fPIC -DPIC -o /home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/objs/.libs/autofit.o
In file included from /home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/autofit.c:37:0:
/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/hbshim.c: In function 'af_get_coverage':
/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/hbshim.c:190:17: error: 'HB_SET_VALUE_INVALID' undeclared (first use in this function)
     for ( idx = HB_SET_VALUE_INVALID; hb_set_next( gsub_lookups, &idx ); )
                 ^
/home/frb15/sagemath/sage-brial/local/var/tmp/sage/build/freetype-2.6/src/src/autofit/hbshim.c:190:17: note: each undeclared identifier is reported only once for each function it appears in

It appears HB_SET_VALUE_INVALID is defined in the harfbuzz library and the version shipped with scientific linux 7.1 (0.9.20) doesn't have it (0.9.38 in gentoo does).

Upstream: Fixed upstream, but not in a stable release.

Component: packages: standard

Author: François Bissey

Branch/Commit: 4afa106

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19089

[kiwifb]

comment:1

Setting --with-harfbuzz=no in spkg-install is somehow insufficient.

[kiwifb]

comment:2

The option does work I had a stray " in spkg-install branch to follow in a bit.

[kiwifb]

comment:3

Ready for review. Note that freetype checks to see if harfbuzz is higher than 0.9.19 but it is obviously too low.

---

Last 10 new commits:

60725e3	Merge remote-tracking branch 'trac/develop' into polybori_autotools
da49082	update to a polybori which includes python bindings
c30cf70	Revert "move polybori python interface into sage"
72965f6	Merge branch 'polybori_autotools' into HEAD
fdff733	switch to BRiAl
5cbf983	rename error messages PolyBoRi -> BRiAl
51a1e98	fix imports polybori -> brial
bf3c56f	brial: clean out old polybori and brial installations before installing
7aadcf2	remove unused library gd from pbori
d3b9d9e	disable harfbuzz for distro with a version of harfbuzz that is not high enough

[kiwifb]

Commit: d3b9d9e

[kiwifb]

Author: François Bissey

[kiwifb]

Branch: u/fbissey/freetype

[kiwifb]

Upstream: Reported upstream. No feedback yet.

[kiwifb]

comment:4

Didn't mean to pull #18437, I will have to redo the branch. Reported upstream:
https://savannah.nongnu.org/bugs/index.php?45828

[sagetrac-git]

Changed commit from d3b9d9e to 4afa106

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4afa106

disable harfbuzz for distro with a version of harfbuzz that is not high enough

[kiwifb]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

[jdemeyer]

comment:9

I can't test that it fixes the problem, but at least the fix makes sense.

[jdemeyer]

Reviewer: Jeroen Demeyer

[kiwifb]

comment:10

It is probably a rare condition as you need to have the development packages for harfbuzz in the first place. And you need to have just the "right" version from 0.9.19 to 0.9.21.

[vbraun]

Changed branch from u/fbissey/freetype to 4afa106