Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse sage-spkg options in sage-spkg #19104

Closed
jdemeyer opened this issue Aug 27, 2015 · 16 comments
Closed

Parse sage-spkg options in sage-spkg #19104

jdemeyer opened this issue Aug 27, 2015 · 16 comments

Comments

@jdemeyer
Copy link

Instead of parsing the options to sage -i both in src/bin/sage and in sage-spkg, parse them just in sage-spkg (without requiring a specific order).

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: 4eb1aa8

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/19104

@jdemeyer jdemeyer added this to the sage-6.9 milestone Aug 27, 2015
@jdemeyer
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 27, 2015

Commit: 31ff6e7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 27, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

31ff6e7Parse sage-spkg options in sage-spkg

@vbraun
Copy link
Member

vbraun commented Aug 28, 2015

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Aug 29, 2015

Changed branch from u/jdemeyer/parse_sage_spkg_options_in_sage_spkg to 31ff6e7

@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

comment:6

This ticket breaks sage -sdist for me

@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

Changed commit from 31ff6e7 to none

@vbraun vbraun reopened this Sep 4, 2015
@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

Changed branch from 31ff6e7 to u/jdemeyer/parse_sage_spkg_options_in_sage_spkg

@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

Commit: 31ff6e7

@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

New commits:

31ff6e7Parse sage-spkg options in sage-spkg

@vbraun
Copy link
Member

vbraun commented Sep 4, 2015

comment:8

Tries to compile patch and then fails with weird errors, something wrong with environment variables I guess.

PS: I can compile just patch (sage -f patch) just fine, for the record

@jdemeyer
Copy link
Author

jdemeyer commented Sep 4, 2015

comment:9

Did you test with just this ticket, or with #19101 and other tickets?

@jdemeyer
Copy link
Author

jdemeyer commented Sep 4, 2015

comment:10

Got it, just forgot support for SAGE_INSTALL_FETCH_ONLY.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 5, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

4eb1aa8Restore SAGE_INSTALL_FETCH_ONLY support

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 5, 2015

Changed commit from 31ff6e7 to 4eb1aa8

@vbraun
Copy link
Member

vbraun commented Sep 6, 2015

Changed branch from u/jdemeyer/parse_sage_spkg_options_in_sage_spkg to 4eb1aa8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants