Make LiE a new-style spkg

[tscrim]

Convert LiE over to a new-style spkg.

Tarball here (just a renamed version of the compile only version on the homepage).

CC: @vbraun @jdemeyer @jhpalmieri

Component: packages: optional

Author: Travis Scrimshaw

Branch: b549677

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19176

[tscrim]

Attachment: lie-2.2.2.tar.gz

Renamed tarball of upstream

[tscrim]

Branch: u/tscrim/lie_new_style_spkg-19176

[tscrim]

Commit: 3e833f6

[tscrim]

New commits:

3e833f6

Making LiE an optional spkg.

[tscrim]

Author: Travis Scrimshaw

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a5d3318

Revert change to GAP3 checksum.

[sagetrac-git]

Changed commit from 3e833f6 to a5d3318

[jdemeyer]

comment:3

This clearly should be removed:

== SPKG Maintainer ==

 * William Stein (?)
 * Michael Abshoff (?)

Similar to #19177, it's recommended to add a dependencies file.

[sagetrac-git]

Changed commit from a5d3318 to 29b768b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cc194fa	Make cluster_seed-1.0 into database_mutation_class-1.0.
29b768b	Tweaks from Jeroen's comments.

[sagetrac-git]

Changed commit from 29b768b to ac4c6be

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac4c6be

Tweaks from Jeroen's comments.

[tscrim]

comment:7

Whoops, don't know how cc194fa got in there.

Fixed.

[jdemeyer]

comment:8

Is the package called lie or conlie? You should be consistent...

[jdemeyer]

comment:9

Sorry, too fast.

[tscrim]

comment:10

The package is called LiE. The upstream tarball is the only thing that is called conlie AFAIK.

[jdemeyer]

comment:11

The package installs fine.

[jdemeyer]

comment:20

If you use os.path.join, it should be better be used as

os.path.join(SAGE_LOCAL, 'lib', 'LiE', 'INFO.0')

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1f6966d

Implementing Jeroen's comments.

[sagetrac-git]

Changed commit from 2df36fc to 1f6966d

[jdemeyer]

comment:23

Despite the claim that the package has no dependencies, it seems to depend at least on readline and ncurses:

gcc -o Lie.exe lexer.o parser.o non-ANSI.o bigint.o binmat.o creatop.o gettype.o getvalue.o init.o learn.o main.o mem.o node.o onoff.o output.o poly.o sym.o print.o get
l.o date.o static/*.o box/*.o -lreadline -lncurses

[tscrim]

comment:24

It also depends on bison, but that can be a system-wide installation (instead of the experimental spkg).

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

comment:25

Replying to @tscrim:

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

Both please.

The package installs and doctests pass, so for the rest it's good for me.

[sagetrac-git]

Changed commit from 1f6966d to dda134f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dda134f

Added dependencies for LiE.

[tscrim]

comment:27

Done. Thanks for walking me though things.

[sagetrac-git]

Changed commit from dda134f to b549677

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b549677

Making the dependencies file more standard.

[jdemeyer]

comment:29

Dependencies look good. I will do one final check with make distclean.

[tscrim]

comment:31

Thanks again.

[vbraun]

Changed branch from u/tscrim/lie_new_style_spkg-19176 to b549677

[jdemeyer]

comment:33

Breakage: #19239

[jdemeyer]

Changed commit from b549677 to none