Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid a %crun crash #19185

Closed
nathanncohen mannequin opened this issue Sep 10, 2015 · 10 comments
Closed

Avoid a %crun crash #19185

nathanncohen mannequin opened this issue Sep 10, 2015 · 10 comments
Labels
p: major / 3 t: bug t: performance
Milestone
sage-6.9

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 10, 2015

When typing several times in a row the following command (which is indeed incorrect)

sage: %crun -s cumulative 1+1

Sage ends up crashing. That's apparently because the timer is started but not stopped (because of the exception).

This very small branch fixes the problem, and may possibly also fix the other occurrences of a crash due to this function. It happens from time to time on my computer, though the previous example at least is deterministic.

I do not know how exactly I should doctest it, though.

CC: @vbraun @simon-king-jena

Component: performance

Author: Nathann Cohen

Branch/Commit: 28dd224

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/19185
@nathanncohen nathanncohen mannequin added this to the sage-6.9 milestone Sep 10, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 10, 2015

New commits:

302e6bctrac #19133: Three Witt-based strongly regular graphs
6c0c890trac #19133: Merged with 6.9.beta5
3bc31a1trac #19133: Broken doctests
7cbfa8btrac #19180: A (220,84,38,28)-strongly regular graph
94437a9trac #19185: Avoid a %crun crash

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 10, 2015

Branch: public/19185

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 10, 2015

Commit: 94437a9

@nathanncohen nathanncohen mannequin added the s: needs review label Sep 10, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2015

Changed commit from 94437a9 to 28dd224

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

28dd224trac #19185: Avoid a %crun crash

@fchapoton
Copy link
Contributor

comment:3

ok, bot is happy and this looks good enough

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 12, 2015

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 12, 2015

comment:5

Reviewer name missing

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Sep 14, 2015

Changed branch from public/19185 to 28dd224

@vbraun vbraun closed this as completed in 1719fc4 Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug t: performance
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
2 participants
@vbraun @fchapoton