Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_planar() fails with an immutable graph #19193

Closed
jm58660 mannequin opened this issue Sep 12, 2015 · 9 comments
Closed

is_planar() fails with an immutable graph #19193

jm58660 mannequin opened this issue Sep 12, 2015 · 9 comments
Labels
c: graph theory p: major / 3 t: bug
Milestone
sage-6.9

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 12, 2015 

sage: Posets.ChainPoset(2).cover_relations_graph().is_planar()
True
sage: Posets.BooleanLattice(3).cover_relations_graph().is_planar()
 . . . ValueError: To relabel an immutable graph use inplace=False

CC: @nathanncohen

Component: graph theory

Author: Jori Mäntysalo

Branch/Commit: 24280ff

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/19193
@jm58660 jm58660 mannequin added this to the sage-6.9 milestone Sep 12, 2015
@jm58660 jm58660 mannequin added c: graph theory labels Sep 12, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 12, 2015

comment:1

FYI: I was doing #19191 when I noticed this.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 13, 2015

comment:2

Here is the same without reference to posets:

sage: G = graphs.PetersenGraph()
sage: G1 = G.copy(immutable=True)
sage: G1.is_planar()

--> Same ValueError.

@jm58660 jm58660 mannequin changed the title is_planar() tries to mutate an immutable graph is_planar() fails with an immutable graph Sep 13, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 18, 2015

Branch: u/jmantysalo/is_planar___fails_with_an_immutable_graph

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 18, 2015

comment:4

Fixed.

New commits:

24280ffFix for is_planar() on immutable graphs.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 18, 2015

Commit: 24280ff

@jm58660 jm58660 mannequin added the s: needs review label Sep 18, 2015
@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 18, 2015

Reviewer: Nathann Cohen

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 18, 2015

comment:5

Okayokayyyyyyyyy. Thanks for the fix,

Nathann

P.S.: Please fill the 'author' field.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 18, 2015

Author: Jori Mäntysalo

@vbraun
Copy link
Member

vbraun commented Sep 18, 2015

Changed branch from u/jmantysalo/is_planar___fails_with_an_immutable_graph to 24280ff

@vbraun vbraun closed this as completed in a9354cf Sep 18, 2015
@jm58660 jm58660 mannequin mentioned this issue Sep 22, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
1 participant
@vbraun