New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suzuki-related strongly regular graphs #19216
Comments
Commit: |
Branch: public/19216 |
comment:2
this seems to be the place where using GAP instead of libGAP makes things much slower... |
comment:3
also, if we care about being fast, the faster way to build the graph on 416 vertices |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Merging this branch with the NO/NU branch was unnecessary (as was probably proved by the fact that there was no conflict) and results in a very unclean history, that I find very hard to read if I have to review the commits that you added. |
comment:7
I pushed back my original branch, on top of which I cherry-picked (git terminology) what I believe to be the only two commits that you added that are related to this branch. I also updated their message so that it contains the ticket number (please do this in the future). I did not overwrite I agree with your two commits, and I thank you for the improvements and addition. You also told me often to use libgap, and I often forget to. Sorry for that. Please check that I did not miss any of the commits you wanted to see here, and set the ticket to Nathann New commits:
|
Changed branch from public/19216 to u/ncohen/19216 |
comment:8
Replying to @nathanncohen:
Apologies. Probably my develop branch is messed up, and messing up anything on top of it. Anyhow, I did not overwrite anything this time. |
Reviewer: Dima Pasechnik |
comment:10
by the way, how about reorganising the source of strongly_regular_db: namely, moving all the graph constructions out of there, say, to generators/srg.py(x) ? |
comment:11
Hmmmmm... Everything in "generators/" is usually exposed in To me having this stuff in this file means that it is not very important of its own. What about only reorganizing the file by moving all the graph constructors at the end of it? It does not bother me much personally. Nathann |
comment:12
Thank you for this review, by the way. Nathann |
Changed branch from u/ncohen/19216 to |
This ticket adds several Suzuki-related groups and graphs.
Depends on #19184
CC: @dimpase
Component: graph theory
Author: Nathann Cohen
Branch/Commit:
262998b
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/19216
The text was updated successfully, but these errors were encountered: