Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suzuki-related strongly regular graphs #19216

Closed
nathanncohen mannequin opened this issue Sep 15, 2015 · 19 comments
Closed

Suzuki-related strongly regular graphs #19216

nathanncohen mannequin opened this issue Sep 15, 2015 · 19 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 15, 2015

This ticket adds several Suzuki-related groups and graphs.

Depends on #19184

CC: @dimpase

Component: graph theory

Author: Nathann Cohen

Branch/Commit: 262998b

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/19216

@nathanncohen nathanncohen mannequin added this to the sage-6.9 milestone Sep 15, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 15, 2015

New commits:

006fa91trac #19184: HigmanSims design
a380d6dtrac #19184: SRG on 105 vertices for L(3,4)
6c56ddatrac #19216: Suzuki-related strongly regular graphs

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 15, 2015

Commit: 6c56dda

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 15, 2015

Branch: public/19216

@nathanncohen nathanncohen mannequin added the s: needs review label Sep 15, 2015
@dimpase
Copy link
Member

dimpase commented Sep 15, 2015

comment:2

this seems to be the place where using GAP instead of libGAP makes things much slower...

@dimpase
Copy link
Member

dimpase commented Sep 15, 2015

comment:3

also, if we care about being fast, the faster way to build the graph on 416 vertices
is from its automorphism group, which is available as Atlas group:

http://brauer.maths.qmul.ac.uk/Atlas/v3/exc/G24/

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

848a972trac #19184: the SRG at last !
fbe7bb9trac #19184: Broken doctest
2ceb7eeMerge branch 'public/19184' of git://trac.sagemath.org/sage into hs
a0eabd4cite [BvL84]
c07f2bcno need to take complement
994aa33SRG on 105 vertices for L(3,4)
8d615c2less crude code in SRG_176_49_12_14
717e356Merge branch 'public/19184' of git://trac.sagemath.org/sage into hs
e8c2668Merge remote-tracking branch 'trac/public/19216' into suz
9fac0293.5-fold speedup of SRG_560 using libgap

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2015

Changed commit from 6c56dda to 9fac029

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 16, 2015

Changed commit from 9fac029 to 4d8c733

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 16, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

4d8c733optimised constuction of SRG_416_100_36_20 and added SRG_144_39_6_12

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

comment:6

Merging this branch with the NO/NU branch was unnecessary (as was probably proved by the fact that there was no conflict) and results in a very unclean history, that I find very hard to read if I have to review the commits that you added.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

Changed commit from 4d8c733 to 262998b

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

comment:7

I pushed back my original branch, on top of which I cherry-picked (git terminology) what I believe to be the only two commits that you added that are related to this branch. I also updated their message so that it contains the ticket number (please do this in the future).

I did not overwrite public/19216 but pushed everything to u/ncohen/19216, you can thus find your old branch if you need it. In the future, however, please ask me whenever you want to see one of my tickets merged with something else, as by doing it yourself you give me much more work.

I agree with your two commits, and I thank you for the improvements and addition. You also told me often to use libgap, and I often forget to. Sorry for that.

Please check that I did not miss any of the commits you wanted to see here, and set the ticket to positive_review if you agree with it. Please fill your name in the 'reviewer' field, or Volker will invalidate the ticket.

Nathann


New commits:

b049232trac #19216: 3.5-fold speedup of SRG_560 using libgap
262998btrac #19216: optimised constuction of SRG_416_100_36_20 and added SRG_144_39_6_12

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

Changed branch from public/19216 to u/ncohen/19216

@dimpase
Copy link
Member

dimpase commented Sep 16, 2015

comment:8

Replying to @nathanncohen:

Merging this branch with the NO/NU branch was unnecessary (as was probably proved by the fact that there was no conflict) and results in a very unclean history, that I find very hard to read if I have to review the commits that you added.

Apologies. Probably my develop branch is messed up, and messing up anything on top of it. Anyhow, I did not overwrite anything this time.
(I looked what I did, and I merged it over Higman-Sims design ticket, as I didn't want to trigger a big recompile, and then, when I decided to add/change stuff, I forgot about it... :-[)

@dimpase
Copy link
Member

dimpase commented Sep 16, 2015

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Sep 16, 2015

comment:10

by the way, how about reorganising the source of strongly_regular_db: namely, moving all the graph constructions out of there, say, to generators/srg.py(x) ?

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

comment:11

Hmmmmm... Everything in "generators/" is usually exposed in graphs.<tab>, and in this case I am not sure that we want that.

To me having this stuff in this file means that it is not very important of its own. What about only reorganizing the file by moving all the graph constructors at the end of it? It does not bother me much personally.

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Sep 16, 2015

comment:12

Thank you for this review, by the way.

Nathann

@vbraun
Copy link
Member

vbraun commented Sep 17, 2015

Changed branch from u/ncohen/19216 to 262998b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants