Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve register_unpickle_override() doc #19242

Closed
jdemeyer opened this issue Sep 18, 2015 · 10 comments
Closed

Improve register_unpickle_override() doc #19242

jdemeyer opened this issue Sep 18, 2015 · 10 comments

Comments

@jdemeyer
Copy link

When the error messages and documentation of the unpickler more user-friendly.

Component: documentation

Author: Jeroen Demeyer

Branch/Commit: 96e992b

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/19242

@jdemeyer jdemeyer added this to the sage-6.9 milestone Sep 18, 2015
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: 96e992b

@jdemeyer
Copy link
Author

New commits:

96e992bImprove register_unpickle_override() documentation

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 19, 2015

comment:3

I can read this and check if I understand the documentation.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 19, 2015

Reviewer: Jori Mäntysalo

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 19, 2015

comment:4

Patch seems good. Only few spaces missing, like def __init__(self,value) should be def __init__(self, value).

No positive review yet, as I am compiling this with old and slow computer.

@jdemeyer
Copy link
Author

comment:5

Replying to @jm58660:

def __init__(self,value) should be def __init__(self, value).

Maybe, but note that this ticket isn't called "fix every small mistake in the sage_object.pyx documentation".

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 19, 2015

comment:6

Replying to @jdemeyer:

Maybe, but note that this ticket isn't called "fix every small mistake in the sage_object.pyx documentation".

:=) Don't worry, they are not obstacle to review. I just noticed them on the lines you have touched. And I like to nitpick sometimes.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Sep 20, 2015

comment:7

Compiled. Looks good.

@vbraun
Copy link
Member

vbraun commented Sep 20, 2015

Changed branch from u/jdemeyer/improve_register_unpickle_override___doc to 96e992b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants