Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not test SageKernelSpec.update() #19243

Closed
jdemeyer opened this issue Sep 19, 2015 · 7 comments
Closed

Do not test SageKernelSpec.update() #19243

jdemeyer opened this issue Sep 19, 2015 · 7 comments
Labels
p: blocker / 1 t: bug t: tests
Milestone
sage-6.9

Comments

@jdemeyer
Copy link

We do not test installing a kernel spec, since it requires write access to $HOME. However, in one test, we forgot to add # not tested.

Component: doctest coverage

Author: Jeroen Demeyer

Branch/Commit: 017d303

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19243
@jdemeyer jdemeyer added this to the sage-6.9 milestone Sep 19, 2015
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/do_not_test_sagekernelspec_update__

@jdemeyer
Copy link
Author

Commit: 017d303

@jdemeyer
Copy link
Author

New commits:

017d303Do not test SageKernelSpec.update()

@jdemeyer
Copy link
Author

comment:3

Blocker since this is a regression since sage-6.9.beta7

@tscrim
Copy link
Collaborator

tscrim commented Sep 21, 2015

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 21, 2015

comment:4

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 22, 2015

Changed branch from u/jdemeyer/do_not_test_sagekernelspec_update__ to 017d303

@vbraun vbraun closed this as completed in 019923e Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: blocker / 1 t: bug t: tests
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer