Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation fix in tilings.py #19260

Closed
sagetrac-tmonteil mannequin opened this issue Sep 20, 2015 · 11 comments
Closed

documentation fix in tilings.py #19260

sagetrac-tmonteil mannequin opened this issue Sep 20, 2015 · 11 comments
Labels
c: documentation p: major / 3 t: bug
Milestone
sage-6.9

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Sep 20, 2015

In the doc of combinat/tiling.py, the coordinates are required to be positive, while they should only be required to be nonnegative.

CC: @seblabbe

Component: documentation

Author: Thierry Monteil

Branch/Commit: c4ca8d4

Reviewer: Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/19260
@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-6.9 milestone Sep 20, 2015
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 20, 2015

Branch: u/tmonteil/documentation_fix_in_tilings_py

@sagetrac-tmonteil

This comment has been minimized.

Sign in to view
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 20, 2015

Author: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 20, 2015

New commits:

c4ca8d4#19260 : positive -> nonnegative.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Sep 20, 2015

Commit: c4ca8d4

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 20, 2015

comment:3

You people need something to keep you busy.

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 20, 2015

Reviewer: Nathann Cohen

@seblabbe
Copy link
Contributor

comment:4

Anyways, it was code to keep me busy:) http://planet.sagemath.org/

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Sep 21, 2015

comment:5

Wow, nice blog entry ;-)

@seblabbe
Copy link
Contributor

comment:6

I think this ticket will create a conflict with #19107. It might be easier for me to fix this inside #19107 rather than rebase my branch...

This has already been positively reviewed... Is it too late?

@vbraun
Copy link
Member

vbraun commented Sep 23, 2015

Changed branch from u/tmonteil/documentation_fix_in_tilings_py to c4ca8d4

@vbraun vbraun closed this as completed in b35f56a Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
2 participants
@vbraun @seblabbe