Default facade=True for order_ideals_lattice()

[jm58660]

facade=True is default for posets in general, and at least #17051 was accepted. Hence I suggest changing order_ideals_lattice() to also have that same default.

CC: @nathanncohen @fchapoton

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: 097ac4e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/19265

[jm58660]

Branch: u/jmantysalo/default_facade_true_for_order_ideals_lattice__

[jm58660]

comment:2

Logical change, I think. Nathann, a review?

---

New commits:

0759135

Change default of facade to true in order_ideals_lattice().

[jm58660]

Commit: 0759135

[nathanncohen]

comment:3

Hmmmmmm... I can't say that I don't want to see the end of these non-facade things, but I am not sure that I should be the one to positive-review them, especially for this reason.

In the present case, however, I'd say that the logical change would be to define the default of facade to match the facade status of the actual poset it was built from.

i.e. if you wanted a non-facade poset, you probably want a non-facade order ideal.

I add frederic in Cc, he might have an opinion on this.

Nathann

[sagetrac-git]

Changed commit from 0759135 to 097ac4e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

097ac4e

New default value for facade: None. (=take it from the poset)

[jm58660]

comment:5

Replying to @nathanncohen:

In the present case, however, I'd say that the logical change would be to define the default of facade to match the facade status of the actual poset it was built from.

You are right. I made a new commit according to that.

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:6

lgtm

[vbraun]

Changed branch from u/jmantysalo/default_facade_true_for_order_ideals_lattice__ to 097ac4e