Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve statistic name and add collection name plural to FindStat interface #19307

Closed
stumpc5 opened this issue Sep 29, 2015 · 25 comments
Closed

Improve statistic name and add collection name plural to FindStat interface #19307

stumpc5 opened this issue Sep 29, 2015 · 25 comments
Labels
c: interfaces: optional p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@stumpc5
Copy link
Contributor

stumpc5 commented Sep 29, 2015

CC: @mantepse

Component: interfaces: optional

Keywords: FindStat

Author: Christian Stump

Branch/Commit: e94f996

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/19307
@stumpc5 stumpc5 added this to the sage-6.9 milestone Sep 29, 2015
@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 29, 2015

Branch: u/stumpc5/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface

@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 29, 2015

New commits:

836f205improved statistic name, added collection name plural, some cosmetic changes as well

@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 29, 2015

Changed keywords from none to FindStat

@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 29, 2015

Commit: 836f205

@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 29, 2015

Author: Christian Stump

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

601599dremoved two references to generating functions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 29, 2015

Changed commit from 836f205 to 601599d

@stumpc5
Copy link
Contributor Author

stumpc5 commented Oct 6, 2015

comment:4

Should we then remove all the tabulation from this ticket? Also, does it sound right to merge name and name_plural into name with an optional argument?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1798c37cleaned two lines of code as discussed
5b42946remove name_plural and change to name, because these belong to ticket #19307
1fe70f7do not produce None in _compute_generating_functions, add doctest, fix hyperlinks
4d6e9ebbugfix
01729f8added a min values counter test
c41472fadded a min values counter doctest
edc3e89fixed some doctests, all tests pass now
025e774a few fixes to error messages
65fb912trivial merge
a531c70added back the changes, based on #19296

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Changed commit from 601599d to a531c70

@stumpc5
Copy link
Contributor Author

stumpc5 commented Oct 9, 2015

Dependencies: #19296

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

5826300merged name and name_plural + typos + doctext fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Changed commit from a531c70 to 5826300

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 14, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

8d3d272Merge branch 'develop' into t/19307/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 14, 2015

Changed commit from 5826300 to 8d3d272

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Changed commit from 8d3d272 to cd9112c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

cd9112cmerged develop

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1fe70f7do not produce None in _compute_generating_functions, add doctest, fix hyperlinks
4d6e9ebbugfix
01729f8added a min values counter test
c41472fadded a min values counter doctest
edc3e89fixed some doctests, all tests pass now
025e774a few fixes to error messages
65fb912trivial merge
a531c70added back the changes, based on #19296
5826300merged name and name_plural + typos + doctext fixes
8d3d272Merge branch 'develop' into t/19307/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Changed commit from cd9112c to 8d3d272

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

6c7099aMerge branch 'develop' into t/19296/generating_function_in_findstat_interface
3bb57edmerged 6.10.rc0 and fixed conflicts
e94f996Merge branch 't/19296/generating_function_in_findstat_interface' into t/19307/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 16, 2015

Changed commit from 8d3d272 to e94f996

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:12

ok, let it be

@fchapoton fchapoton modified the milestones: sage-6.9, sage-7.1 Mar 16, 2016
@fchapoton
Copy link
Contributor

Changed dependencies from #19296 to none

@vbraun
Copy link
Member

vbraun commented Mar 20, 2016

Changed branch from u/stumpc5/improve_statistic_name_and_add_collection_name_plural_to_findstat_interface to e94f996

@vbraun vbraun closed this as completed in b2d7828 Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces: optional p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @stumpc5 @fchapoton