New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move invariant_generators to libsingular #19391
Comments
Branch: u/mmarco/invariants |
comment:3
The code now is simpler. But there was a reason to have it like that: Singular isn't good at listing the elements of a group (which is needed for the Reynolds operator). If I recall correctly, there were examples for which the computation of the Reynolds operator in Singular was too slow. Apparently these examples didn't go into the doctests. But perhaps they are available at the trac ticket for the original version of the code? New commits:
|
Commit: |
comment:4
Ok, i read in the header that you moved the computation of the reynolds operator to gap, but i didn't see any call to gap in the code. Now i see it, you mean this part, right?:
What i don't understand is this part:
If i am getting it right, it is supposed to cover the case where there are no elements in the group. In that case we should just return the ring itself. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Ok, now it computes the reynolds operator before passing it to singular. I am now working on the modular case. I having trouble getting the output of invariant_ring from libsingular. The singular command is supposed to return three matrices, but calling it through libsingular only gets the first one:
Any clue about how to get around this? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Ok, i think it should be ok now. I added the modular case. I think that this code should be faster than the previous one, since it does the same, but using the faster libsingular interface rather than the string based one. If you have some interesting examples to test, please benchmark them. |
comment:9
merge conflict. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
one failing doctest (shift in the indices) |
Changed branch from u/mmarco/invariants to public/ticket/19391 |
comment:15
is there anybody around still interested in this ticket ? It now passes the doctests. It may deserve some benchmarking. |
comment:16
For my part, i would set it to positive review if you agree. |
comment:17
I would like to have at least one benchmark here (before / after), please. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:19
Surprisingly, I have found that the new code is actually a few miliseconds slower that the older one. While at profiling, I also caught a possible source of segfaults. New commits:
|
comment:20
red branch => needs_work |
This patch moves the .invariant_generators() method of finite matrix groups to libsingular, which simplifies much the code.
It also adds the possibility of defining the ring in which the result should be:
CC: @simon-king-jena @wdjoyner
Component: group theory
Author: Miguel Marco
Branch/Commit: public/ticket/19391 @
ea82aa9
Issue created by migration from https://trac.sagemath.org/ticket/19391
The text was updated successfully, but these errors were encountered: