Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of libtool archives (*.la) #19549

Closed
vbraun opened this issue Nov 8, 2015 · 12 comments
Closed

Get rid of libtool archives (*.la) #19549

vbraun opened this issue Nov 8, 2015 · 12 comments

Comments

@vbraun
Copy link
Member

vbraun commented Nov 8, 2015

  • They are a nuisance since they can't contain relative paths.
  • Fedora packaging guide line says "Libtool archives, foo.la files, should not be included"
  • the whole idea of Libtool Archives is, nowadays, considered obsolete (https://autotools.io/libtool/lafiles.html)
  • Anything that can be done with libtool archives can be done better with pkg-config

CC: @kiwifb

Component: build

Keywords: sd70

Author: Volker Braun

Branch/Commit: dc6d482

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/19549

@vbraun vbraun added this to the sage-6.10 milestone Nov 8, 2015
@vbraun
Copy link
Member Author

vbraun commented Nov 8, 2015

Changed keywords from none to sd70

@vbraun
Copy link
Member Author

vbraun commented Nov 8, 2015

comment:2

Francois, any objection?

@kiwifb
Copy link
Member

kiwifb commented Nov 8, 2015

comment:3

Replying to @vbraun:

Francois, any objection?

None.

@kiwifb
Copy link
Member

kiwifb commented Nov 8, 2015

comment:4

I am not sure what other answer you were expecting from me. Distros like Gentoo (and most others I would think) get rid of them. The good question is how to do it in sage? The easiest way would be for sage-spkg to do the scanning. We don't want it to be done as an afterthought once the sage build is finished.

The problem is that you don't have a staging phase before putting the file in your tree. So you cannot stage then remove the ugly stuff and then put it in your tree (or prefix if you will). Which means that essentially you may have to scan the whole $SAGE_LOCAL/lib for .la file after you have issued make install for every package. Could it be added to sage-spkg to do once spkg-install proper is finished? How would that interact with spkg-check is also something to think about because building test may rely on these .la files.

@vbraun
Copy link
Member Author

vbraun commented Nov 10, 2015

Branch: u/vbraun/get_rid_of_libtool_archives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2015

Commit: dc6d482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dc6d482Erase libtool archive files after running spkg-install

@vbraun
Copy link
Member Author

vbraun commented Nov 10, 2015

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Nov 10, 2015

comment:7

I'm just deleting them after spkg-check; Not sure if its necessary but can't hurt.

@kiwifb
Copy link
Member

kiwifb commented Nov 10, 2015

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Nov 10, 2015

comment:8

That'll do, it will depend on the package. In m4rie test are built during make all. Not really fantastic in my opinion but that's a case where it wouldn't be necessary.

@vbraun
Copy link
Member Author

vbraun commented Nov 11, 2015

Changed branch from u/vbraun/get_rid_of_libtool_archives to dc6d482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants