Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad caching of FiniteEnumeratedSet #19562

Open
videlec opened this issue Nov 9, 2015 · 8 comments
Open

Fix bad caching of FiniteEnumeratedSet #19562

videlec opened this issue Nov 9, 2015 · 8 comments
Labels
c: combinatorics p: major / 3 s: needs work t: bug
Milestone
sage-6.10

Comments

@videlec
Copy link
Contributor

videlec commented Nov 9, 2015

Currently

sage: F1 = FiniteEnumeratedSet((1,2,3))
sage: F2 = FiniteEnumeratedSet((1., 2., 3.))
sage: F2.an_element().parent()
Integer Ring

We fix this problem by computing a universe associated to each FiniteEnumeratedSet.

CC: @tscrim @nthiery @hivert

Component: combinatorics

Work Issues: failing doctests

Author: Vincent Delecroix

Branch/Commit: u/vdelecroix/19562 @ 3410bed

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/19562
@videlec videlec added this to the sage-6.10 milestone Nov 9, 2015
@videlec
Copy link
Contributor Author

videlec commented Nov 9, 2015

New commits:

3410bedTrac 19562: fix caching of FiniteEnumeratedSet

@videlec
Copy link
Contributor Author

videlec commented Nov 9, 2015

Commit: 3410bed

@videlec
Copy link
Contributor Author

videlec commented Nov 9, 2015

Branch: u/vdelecroix/19562

@saraedum
Copy link
Member

comment:2

I think raising an ArgumentError would be more appropriate here than a simple assert. After all, one of the arguments is invalid.

@saraedum
Copy link
Member

comment:3

Other than that, feel free to set it to positive review yourself.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@tscrim
Copy link
Collaborator

tscrim commented Nov 19, 2015

comment:6

And after figuring out why all of those doctests are now failing.

@saraedum
Copy link
Member

Work Issues: failing doctests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 s: needs work t: bug
Projects
None yet
Milestone
sage-6.10
Development

No branches or pull requests
3 participants
@saraedum @tscrim @videlec