Symmetric square L-functions for modular forms

[loefflerd]

Martin Raum has posted on sage-nt code for computing the symmetric square L-functions of (level 1) modular forms. The goal of this ticket is to get Martin's code into Sage.

CC: @sagetrac-mraum

Component: modular forms

Author: Martin Raum, David Loeffler

Branch/Commit: 376cc2f

Reviewer: Marc Masdeu

Issue created by migration from https://trac.sagemath.org/ticket/19668

[loefflerd]

Branch: u/davidloeffler/symmetric_square_l_functions_for_modular_forms

[loefflerd]

Commit: a498b43

[loefflerd]

New commits:

a498b43

Trac 19668: Symmetric square L-functions for modular forms

[loefflerd]

comment:3

Oops, I forgot to run long doctests, and one of them is failing on the patchbot.

[sagetrac-git]

Changed commit from a498b43 to 0cd82a6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0cd82a6

Trac 19669: fix a broken doctest

[loefflerd]

comment:5

That's better. This is now ready for review. (The code should work for certain higher-level forms -- trivial character and squarefree level should be OK -- but that can come in a subsequent ticket; for now it just raises NotImplementedError if the level isn't 1.)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9ba1341

Trac 19668: remove deprecated "raise" syntax

[sagetrac-git]

Changed commit from 0cd82a6 to 9ba1341

[loefflerd]

comment:8

One of the patchbot plugins spotted that I had used the old-style, deprecated raise Exception, "message" syntax rather than raise Exception("message"), so here's a tiny patch fixing this.

[loefflerd]

Changed branch from u/davidloeffler/symmetric_square_l_functions_for_modular_forms to public/19668-symsquare

[loefflerd]

comment:10

I noticed that one of the commits had the wrong ticket number in the docstring, so I rewrote the history using "git rebase". The new branch has a single commit, with the correct ticket number; the code is identical to the previously-uploaded branch.

---

New commits:

5066faf

Trac 19668: Symmetric square L-functions for modular forms

[loefflerd]

Changed commit from 9ba1341 to 5066faf

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

376cc2f

Trac #19668: review patch - removed superfluous whitespace, minor edits.

[sagetrac-git]

Changed commit from 5066faf to 376cc2f

[mmasdeu]

comment:12

The implementation looks clean and correct.

I checked that some output was consistent with what is returned from Magma.

It would be worth having a more general implementation (including arbitrary powers, too?). But it's better than nothing, so I'm giving a positive review.

[mmasdeu]

Reviewer: Marc Masdeu

[vbraun]

Changed branch from public/19668-symsquare to 376cc2f