New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move normalize_names() out of CategoryObject #19675
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
jdemeyer
changed the title
make CategoryObject.normalize_names private
move normalize_names() out of CategoryObject
Dec 7, 2015
This comment has been minimized.
This comment has been minimized.
jdemeyer
changed the title
move normalize_names() out of CategoryObject
Move normalize_names() out of CategoryObject
Dec 7, 2015
This comment has been minimized.
This comment has been minimized.
comment:4
Big +1. |
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:9
LGTM. |
Reviewer: Travis Scrimshaw |
Changed branch from u/jdemeyer/make_categoryobject_normalize_names_private to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It makes no sense that
normalize_names
appears in the TAB-completion of allCategoryObject
s. It also makes little sense that it's a method ofCategoryObject
.Move
normalize_names
and_certify_names
out ofCategoryObject
and make them non-method functions.Remove the redundant
parent_gens.normalize_names
,parent_gens._certify_names
,parent.normalize_names
andsage.schemes.toric.variety.certify_names
.Always interpret
ngens=-1
as "unknown number of generators" andngens=0
as "no generators". The previous implementation did this inconsistently.Add doctests.
Note that many more classes should probably use
normalize_names
. I didn't fix this here. Example fromsrc/sage/algebras/jordan_algebra.py
:Component: categories
Author: Jeroen Demeyer
Branch/Commit:
280312f
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/19675
The text was updated successfully, but these errors were encountered: