Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock, pytest, tox, virtualenv optional packages #19680

Closed
jdemeyer opened this issue Dec 8, 2015 · 21 comments
Closed

Add mock, pytest, tox, virtualenv optional packages #19680

jdemeyer opened this issue Dec 8, 2015 · 21 comments

Comments

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add mock, pytest, tox optional packages Add mock, py, pytest, tox optional packages Dec 8, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add mock, py, pytest, tox optional packages Add mock, pytest, tox optional packages + dependencies Dec 8, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add mock, pytest, tox optional packages + dependencies Add mock, pytest, tox, virtualenv optional packages Dec 8, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add mock, pytest, tox, virtualenv optional packages Add mock, nose, pytest, tox, virtualenv optional packages Dec 8, 2015
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add mock, nose, pytest, tox, virtualenv optional packages Add mock, pytest, tox, virtualenv optional packages Dec 8, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2015

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2015

Commit: 353210b

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2015

New commits:

353210bAdd mock, pytest, tox, virtualenv optional packages

@vbraun
Copy link
Member

vbraun commented Dec 27, 2015

comment:11

Can't these all be installed via pip? Why not make them pip-type packages?

@jdemeyer
Copy link
Author

comment:12

Replying to @vbraun:

Can't these all be installed via pip? Why not make them pip-type packages?

Well, I would like to eventually change the build system to make such packages automatic dependencies if SAGE_CHECK=yes. Many Python packages have a test suite, but we don't run them because they require these extra packages.

Since pip packages bypass the usual local/var/lib/sage/installed system, they should not be used as dependencies of other packages.

@vbraun
Copy link
Member

vbraun commented Dec 28, 2015

comment:13

A pip-type package could just update local/var/lib/sage/installed with the output of pip list

IMHO we are going to fight an uphill battle if we keep repackaging more and more of pypi for stuff that has no direct mathematical use. It just wastes our own resources that could be spent elsewhere. We should be relying more on pip, not less.

@jdemeyer
Copy link
Author

comment:14

needs_work because of the old-style dependency lists. Let me know if anybody wants to review this, then I'll make the required changes.

@jdemeyer
Copy link
Author

Work Issues: Dependencies

@kiwifb
Copy link
Member

kiwifb commented May 20, 2016

comment:15

I'll look, we need those for testing.

@vbraun
Copy link
Member

vbraun commented May 29, 2016

comment:16

I think its a bit too much to make all testsuite dependencies de facto standard packages because they are dependencies of standard packages.

How about requiring internet access for building with SAGE_CHECK=yes? Then all those pip packages could just be installed by a script-type check_dependencies package that just contains

if SAGE_CHECK
    pip install -r check-requirements.txt

@mkoeppe
Copy link
Member

mkoeppe commented Jan 13, 2020

comment:17

Replying to @vbraun:

How about requiring internet access for building with SAGE_CHECK=yes? Then all those pip packages could just be installed by a script-type check_dependencies package that just contains

if SAGE_CHECK
    pip install -r check-requirements.txt

I have a version of this in #28998.

@mkoeppe mkoeppe removed this from the sage-7.3 milestone Jun 6, 2020
@orlitzky
Copy link
Contributor

comment:19

Our python situation is unrecognizable from five years ago; this will need to be started from scratch if there's anything to be salvaged.

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants