Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Standard example" poset #19690

Closed
jm58660 mannequin opened this issue Dec 11, 2015 · 25 comments
Closed

Add "Standard example" poset #19690

jm58660 mannequin opened this issue Dec 11, 2015 · 25 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Dec 11, 2015

As #19383 seems dead (and latest push do not merge anymore), I suggest adding standard example in it's own in this ticket.

It is logical to have StandardExample(n) to always have dimension n. This is not the case when n=1. Hence I added a restriction n >= 2.

CC: @fchapoton @tscrim @jhpalmieri

Component: combinatorics

Keywords: poset

Author: Kevin Dilks, Jori Mäntysalo

Branch/Commit: 7c74da6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19690

@jm58660 jm58660 mannequin added this to the sage-6.10 milestone Dec 11, 2015
@jm58660 jm58660 mannequin added the p: major / 3 label Dec 11, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 11, 2015

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 11, 2015

Changed keywords from none to poset

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 11, 2015

Author: Kevin Dilks, Jori Mäntysalo

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 11, 2015

Changed branch from u/jmantysalo/add__standard_example__poset to none

@jm58660

This comment has been minimized.

@jm58660 jm58660 mannequin added t: enhancement labels Dec 11, 2015
@jm58660 jm58660 mannequin modified the milestones: sage-6.10, sage-7.0 Dec 11, 2015
@jm58660 jm58660 mannequin added the s: needs review label Dec 11, 2015
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 26, 2015

Commit: acd7169

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Dec 26, 2015

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 11, 2016

comment:4

Nathann, you already saw this in #19383, so I guess this is an easy review.

Documentation could be extended and said that Dedekind-Macneille completion of standard example is the Boolean lattice. (That is, this is also kind of standard example showing that completion by cuts can be exponential in size.) But then, doc can not say every mathematical fact.

@jm58660

This comment has been minimized.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jan 11, 2016

comment:5

It is, but I do not agree with the terminology and so I chose to not review it.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 11, 2016

comment:6

Replying to @nathanncohen:

It is, but I do not agree with the terminology and so I chose to not review it.

Duh. Travis?

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 18, 2016

comment:7

About terminology: in issue 2/2015 of Order there is a paper titled "Standard Examples as Subposets of Posets". I just can not see what else the name of the poset should be.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 22, 2016

comment:8

John, if you are interested in names... What about this one?

@jhpalmieri
Copy link
Member

comment:9

If the name seems to be widely accepted, okay, but add a reference.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 23, 2016

comment:10

Replying to @jhpalmieri:

If the name seems to be widely accepted, okay, but add a reference.

What kind of reference? Googling founds books "Handbook of Discrete and Combinatorial Mathematics" and "Introduction to Lattice Theory with Computer Science Applications" and there are many papers. And Wikipedia uses the term.

But what is more important, I have not seen this poset named as something else, and neither seen "standard poset" used to refer any other poset.

@jhpalmieri
Copy link
Member

comment:11

I don't know why you are resistant to adding a reference; what harm can it possibly cause? Can't adding a reference only improve the situation? Anyway, you asked my opinion. At least one other person expressed the same opinion. Use wikipedia or use some other reference; I'm not a poset expert, so I don't know what reference would be most definitive.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 23, 2016

comment:12

Replying to @jhpalmieri:

I don't know why you are resistant to adding a reference; what harm can it possibly cause?

No no, I am not against. My question was not rhetorical, but I really asked what the reference should be.

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2016

comment:13

I would add both references.

I made a few tweaks to the documentation. Once you add the references, you can set this to a positive review on my behalf (in part because I can't think of a better name at this point).


New commits:

c2c7fa5Merge branch 'u/jmantysalo/add__standard_example__poset' of trac.sagemath.org:sage into u/jmantysalo/add__standard_example__poset
6b4abd5Some doctest and formatting tweaks.

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2016

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 23, 2016

Changed commit from acd7169 to 6b4abd5

@tscrim tscrim modified the milestones: sage-7.0, sage-7.1 Jan 23, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 24, 2016

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 24, 2016

Changed commit from 6b4abd5 to 7c74da6

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jan 24, 2016

comment:15

Replying to @tscrim:

Once you add the references, you can set this to a positive review on my behalf

OK. Thanks.


New commits:

7c74da6References to standar example.

@vbraun
Copy link
Member

vbraun commented Jan 28, 2016

Changed branch from u/jmantysalo/add_standard_example_poset-19690 to 7c74da6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants