Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coercions involving PolynomialQuotientRings #19741

Closed
mezzarobba opened this issue Dec 18, 2015 · 3 comments
Closed

Fix coercions involving PolynomialQuotientRings #19741

mezzarobba opened this issue Dec 18, 2015 · 3 comments
Labels
c: algebra p: minor / 4 t: bug
Milestone
sage-7.1

Comments

@mezzarobba
Copy link
Member

PolynomialQuotientRing_generic.construction() calls is_field() in attempt to pass as_field=True to QuotientFunctor in some cases. As far as I understand, this is not necessary, and probably even incorrect (PolynomialQuotientRing_generic has no field() method, only number_field(), and NumberFields are constructed using AlgebraicExtensionFunctor, not QuotientFunctor), but this breaks basic arithmetic when polynomial factorization over the cover ring is not implemented.

sage: Pol.<y> = CBF[]            
sage: Quo.<y> = Pol.quotient(y^3)
sage: CBF.zero()*y
...
NotImplementedError:

CC: @simon-king-jena

Component: algebra

Author: Marc Mezzarobba

Branch/Commit: b13d4df

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/19741
@vbraun
Copy link
Member

vbraun commented Jan 17, 2016

Reviewer: Volker Braun

@mezzarobba
Copy link
Member Author

comment:3

Thanks!

@tscrim tscrim added this to the sage-7.1 milestone Jan 26, 2016
@vbraun
Copy link
Member

vbraun commented Jan 28, 2016

Changed branch from u/mmezzarobba/polyquo to b13d4df

@vbraun vbraun closed this as completed Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: minor / 4 t: bug
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mezzarobba