Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Jupyter notebook default files #19746

Closed
vbraun opened this issue Dec 18, 2015 · 10 comments
Closed

Ignore Jupyter notebook default files #19746

vbraun opened this issue Dec 18, 2015 · 10 comments
Labels
c: user interface p: major / 3 t: bug
Milestone
sage-7.0

Comments

@vbraun
Copy link
Member

vbraun commented Dec 18, 2015

Component: notebook

Author: Volker Braun

Branch/Commit: 4cdb14c

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19746
@vbraun vbraun added this to the sage-7.0 milestone Dec 18, 2015
@vbraun
Copy link
Member Author

vbraun commented Dec 18, 2015

Branch: u/vbraun/ignore_jupyter_notebook_default_files

@vbraun
Copy link
Member Author

vbraun commented Dec 18, 2015

Commit: 8b906c0

@vbraun
Copy link
Member Author

vbraun commented Dec 18, 2015

New commits:

8b906c0Ignore Jupyter default files

@vbraun
Copy link
Member Author

vbraun commented Dec 18, 2015

Author: Volker Braun

@jdemeyer
Copy link

comment:3

I don't agree with Untitled.ipynb: that's just one possible filename of a Jupyter notebook. It only works if you make at most 1 notebook.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

4cdb14cAlso ignore Untitled1.ipynb etc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2015

Changed commit from 8b906c0 to 4cdb14c

@vbraun
Copy link
Member Author

vbraun commented Dec 18, 2015

comment:5

Jupyter auto-saves the notebook under Untitled.ipynb when you create the notebook, you cannot avoid it even if you don't want it. That makes is pretty annoying and prone to accidentally check it in. Are we ever going to intentionally check in Untitled.ipynb? If not then its better to ignore.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member Author

vbraun commented Dec 23, 2015

Changed branch from u/vbraun/ignore_jupyter_notebook_default_files to 4cdb14c

@vbraun vbraun closed this as completed in f0e5248 Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: user interface p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.0
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer